OxfordIonTrapGroup / oitg

Python package of helper routines (result loading, fitting, etc) for the Oxford Ion-Trap Group (OITG).
https://oxfordiontrapgroup.github.io/oitg/
13 stars 9 forks source link

Robust attenuated sinusoid fitting #8

Closed pathfinder49 closed 5 years ago

pathfinder49 commented 5 years ago

This function does a similar job to rabi_flop, thought should be more robust. I've left fitting.rabi_flop for now to maintain backwads compatibility.

Feedback welcome.

cjbe commented 5 years ago

@pathfinder49 in the future could you make sure you rebase your commits to make the history tidier (i.e. it won't ever be useful to go back to your 'flake8' commit, or the 'in working state, work in progress' commit).

dnadlinger commented 5 years ago

@cjbe: Thankfully, GitHub now has a "Squash and merge" button.

@pathfinder49: Apparently I lied, seems like test builds don't run anymore. Something broke; I'll have a look…

dnadlinger commented 5 years ago

Documentation builds are at https://oxfordiontrapgroup.github.io/oitg/, by the way.

dnadlinger commented 5 years ago

Oh, what is mostly a copy of this is already in master.

dnadlinger commented 5 years ago

One last thing (since naming is known to be the hardest problem in computer science): What do you think about decaying_sinusoid? Shorter, and arguably more descriptive (it's not just attenuated, as in a range not from -1 to 1, but the attenuation is increasing).