Closed ljstephenson closed 3 years ago
Can't we just use appdirs
as an external dependency (from PyPI, Conda, …)?
Sure, can use external dependency! I can't see what the errors are in build and test; appdirs exists both on PyPi and in conda-forge (latest version), I'm not concrete on what is needed in the meta.yaml file but it looked simple enough.
Does CircleCI disallow access to non-org-members?
Does CircleCI disallow access to non-org-members?
It does, just me being stupid
Apologies, must have missed the update notification – merged!
I don't love this solution; I think it's a little messy that the driver specifies its own directory rather than it being handled at the package level. However, this does work (tested on Windows). Also happy to change the directory location if there are strong opinions, currently on Windows it resolves as
C:\Users\<user>\AppData\Local\oitg\oxart-devices
I called this a breaking change, although it depends on your definition of breaking. Things are definitely funky if you don't copy the file, or set the voltages directly rather than via the mediator.
Solves OxfordIonTrapGroup/oxart-devices#4 by saving the file in a consistent location.
To adapt to this change, users will need to copy the old setpoint file to the new location. Running
python -c "import oxart.devices.thorlabs_mdt69xb.driver as driver; print(driver._get_data_dir())"
will both create the directory and print out its location.