OxfordTechnicalSolutions / gad-sdk

SDK for users of Generic Aiding with OxTS Inertial Navigation Systems.
0 stars 4 forks source link

GAD sdk python wrapper does not support NEU #18

Closed BazKhondkar-design closed 8 months ago

BazKhondkar-design commented 1 year ago

The SDK document talks about NEU but the python wrapper does not support its functionality. Also firmware does not support NED.

What needs to be done for the GAD sdk:

1) Change the enum to the correct type:

typedef enum
{
   VEL_SYS_VOID,
   VEL_SYS_NED,             /** North East Down */
   VEL_SYS_ODO,             /** Aiding source frame - x/y/z */
   VEL_SYS_LOCAL            /** User defined right-handed local coordinate system - x/y/z */
} VEL_SYS_TYPE

Above enum is incorrect and its need to be in the same as the firmware.

typedef enum
{
   VEL_SYS_VOID,
   VEL_SYS_NEU,             // North East Upwards
   VEL_SYS_ODO,             // Aiding source frame - x/y/z
   VEL_SYS_LOCAL            // User defined right-handed local coordinate system - x/y/z
} VEL_SYS_TYPE;

Also the function call need to be vel_neu and not vel_ned

smcca-oxts commented 8 months ago

NEU is a relic from previous versions, now included as NED since this is more consistent with our right-handed conventions around frames. The functionality is fundamentally the same, just with a flipped axis.