OxideWaveLength / Minecraft-Hack-BaseClient

This is a Minecraft Base Client
MIT License
314 stars 48 forks source link

MCP License Violation #79

Open caoimhebyrne opened 3 years ago

caoimhebyrne commented 3 years ago

Your project is in active violation of the MCP license. You are not allowed to distribute the Minecraft source in any way as stated in the license

The license:

License and terms of use.
=========================

No warranties. If MCP does not work for you, or causes any damage, it's your problem. Use it at own risk.

You are allowed to:
- Use MCP to decompile the Minecraft client and server jar files.
- Use the decompiled source code to create mods for Minecraft.
- Recompile modified versions of Minecraft.
- Reobfuscate the classes of your mod for Minecraft.

You are NOT allowed to:
- Use MCP to do anything that violated Mojangs terms of use for Minecraft.
- Release Minecraft versions or modifications that allow you to play without having bought Minecraft from Mojang.
- Release modified or unmodified versions of MCP anywhere.
- Use any of MCPs scripts, tools or data files without explicit written permission.
- Make money with anything based on MCP (excluding Minecraft mods created by using MCP).
- Use MCP to create clients that are used for griefing or exploiting server bugs.
- Release the decompiled source code of Minecraft in any way.

Tagging relevant people: @seargedp

caoimhebyrne commented 3 years ago

You are also in violation of the Optifine license, which doesn't specify a license. If a project does not specify a license, it is known as "All Rights Reserved". I advise you to remove this repository yourself to avoid legal issues :-)

OxideWaveLength commented 3 years ago

I'm aware of the current violations of the project and I am working on a solution for it

caoimhebyrne commented 3 years ago

These are quite serious, the project should not have been open sourced in the first place. As an alternative, you can use something like mixins. https://github.com/SpongePowered/Mixin

OxideWaveLength commented 3 years ago

The solution I'm working on involves diff files and does not redistribute any of minecrafts or optifines source code

stpidgamers commented 3 years ago

shove that fucking license up ur ass and get gud

josephworks commented 3 years ago

LMAO didn't expect that

stpidgamers commented 3 years ago

These are quite serious, the project should not have been open sourced in the first place. As an alternative, you can use something like mixins. https://github.com/SpongePowered/Mixin fuck mixins they bad

caoimhebyrne commented 3 years ago

These are quite serious, the project should not have been open sourced in the first place. As an alternative, you can use something like mixins. https://github.com/SpongePowered/Mixin fuck mixins they bad

I think using mixins is better than a potential DMCA on your project, don't you? You can't say you don't like mixins when I can make a very good assumption that you actually haven't used mixins, and that you probably know nothing about respect :)

josephworks commented 3 years ago

Yeah, mixins kinda really suck. Mine as well do a patch based dev side system like paper.

I'd personally take a dmca rather than add mixins to my project.

OxideWaveLength commented 3 years ago

You're not really risking any DMCA with the patch system, it's been tested and used before. Optifine uses them for their installation, for example. And Spigot does too, as pointed out by @josephworks.

This repository is probably not going to stay, a new one will be created and old users redirected there, which seems like the best option, keeping the best of both worlds safely

Wyvest commented 3 years ago

You're not really risking any DMCA with the patch system, it's been tested and used before. Optifine uses them for their installation, for example. And Spigot does too, as pointed out by @josephworks.

This repository is probably not going to stay, a new one will be created and old users redirected there, which seems like the best option, keeping the best of both worlds safely

2 fun facts:

  1. Optifine and Spigot is not OSS. Do you know why? Because making that OSS would be a violation of the MCP license!
  2. Your solution seems good

also MIXIN ISNT BAD

AverageComet250 commented 3 years ago

I like how the examples for ways this repo can stay oss are private.

Almost defeats the point if you know what I mean.

OxideWaveLength commented 3 years ago

I like how the examples for ways this repo can stay oss are private.

Almost defeats the point if you know what I mean.

It doesn't matter if Optifine is open source or not, they patch Mojang's Minecraft jar on your computer with diff files contained within their installer jar. And, correct me if I'm wrong, but redistributing a modified version of Minecraft as a jar is against Mojang's EULA, so they are effectively getting around it.

Spigot gets around it by patching Mojang's Minecraft server jar and Spigot is open source for the most part, including Bukkit and CraftBukkit (which they maintain).

Them getting around it by letting you patch their software on your computer means that I can get around Mojang and MCP's EULA by letting the user patch their MCP decompiled source code locally using diff files from github and then, finally, download normal source files for the bits of code that don't infringe any license or user agreement (the rest of the client, everything under the "me.wavelength" package).

I could be wrong about all of this so, please, correct me if I'm wrong

Wyvest commented 3 years ago

I like how the examples for ways this repo can stay oss are private.

Almost defeats the point if you know what I mean.

It doesn't matter if Optifine is open source or not, they patch Mojang's Minecraft jar on your computer with diff files contained within their installer jar. And, correct me if I'm wrong, but redistributing a modified version of Minecraft as a jar is against Mojang's EULA, so they are effectively getting around it.

Spigot gets around it by patching Mojang's Minecraft server jar and Spigot is open source for the most part, including Bukkit and CraftBukkit (which they maintain).

Them getting around it by letting you patch their software on your computer means that I can get around Mojang and MCP's EULA by letting the user patch their MCP decompiled source code locally using diff files from github and then, finally, download normal source files for the bits of code that don't infringe any license or user agreement (the rest of the client, everything under the "me.wavelength" package).

I could be wrong about all of this so, please, correct me if I'm wrong

You are misunderstanding what the original complaint was about. You are literally distributing mojang code, Optifine is literally just patch files only and therefore not against mojang eula.

OxideWaveLength commented 3 years ago

I like how the examples for ways this repo can stay oss are private.

Almost defeats the point if you know what I mean.

It doesn't matter if Optifine is open source or not, they patch Mojang's Minecraft jar on your computer with diff files contained within their installer jar. And, correct me if I'm wrong, but redistributing a modified version of Minecraft as a jar is against Mojang's EULA, so they are effectively getting around it.

Spigot gets around it by patching Mojang's Minecraft server jar and Spigot is open source for the most part, including Bukkit and CraftBukkit (which they maintain).

Them getting around it by letting you patch their software on your computer means that I can get around Mojang and MCP's EULA by letting the user patch their MCP decompiled source code locally using diff files from github and then, finally, download normal source files for the bits of code that don't infringe any license or user agreement (the rest of the client, everything under the "me.wavelength" package).

I could be wrong about all of this so, please, correct me if I'm wrong

You are misunderstanding what the original complaint was about. You are literally distributing mojang code, Optifine is literally just patch files only and therefore not against mojang eula.

I mean, have you read the whole conversation? I've said that I'm very aware of that, and that a solution involving diff files is coming soon.

ghost commented 3 years ago

Your project is in active violation of the MCP license. You are not allowed to distribute the Minecraft source in any way as stated in the license

The license:

License and terms of use.
=========================

No warranties. If MCP does not work for you, or causes any damage, it's your problem. Use it at own risk.

You are allowed to:
- Use MCP to decompile the Minecraft client and server jar files.
- Use the decompiled source code to create mods for Minecraft.
- Recompile modified versions of Minecraft.
- Reobfuscate the classes of your mod for Minecraft.

You are NOT allowed to:
- Use MCP to do anything that violated Mojangs terms of use for Minecraft.
- Release Minecraft versions or modifications that allow you to play without having bought Minecraft from Mojang.
- Release modified or unmodified versions of MCP anywhere.
- Use any of MCPs scripts, tools or data files without explicit written permission.
- Make money with anything based on MCP (excluding Minecraft mods created by using MCP).
- Use MCP to create clients that are used for griefing or exploiting server bugs.
- Release the decompiled source code of Minecraft in any way.

Tagging relevant people: @SeargeDP

LMAO you realize there are thousands of clients like these being distributed. Find something else to do smh

Wyvest commented 3 years ago

Your project is in active violation of the MCP license. You are not allowed to distribute the Minecraft source in any way as stated in the license The license:

License and terms of use.
=========================

No warranties. If MCP does not work for you, or causes any damage, it's your problem. Use it at own risk.

You are allowed to:
- Use MCP to decompile the Minecraft client and server jar files.
- Use the decompiled source code to create mods for Minecraft.
- Recompile modified versions of Minecraft.
- Reobfuscate the classes of your mod for Minecraft.

You are NOT allowed to:
- Use MCP to do anything that violated Mojangs terms of use for Minecraft.
- Release Minecraft versions or modifications that allow you to play without having bought Minecraft from Mojang.
- Release modified or unmodified versions of MCP anywhere.
- Use any of MCPs scripts, tools or data files without explicit written permission.
- Make money with anything based on MCP (excluding Minecraft mods created by using MCP).
- Use MCP to create clients that are used for griefing or exploiting server bugs.
- Release the decompiled source code of Minecraft in any way.

Tagging relevant people: @SeargeDP

LMAO you realize there are thousands of clients like these being distributed. Find something else to do smh

doesn't mean this is right though lol

josephworks commented 3 years ago

I think we should get this closed, @dreamhopping this isn't your issue and it doesn't affect you (unless you are a Mojang dev, and if you are [most likely not], then you aren't handling this how Mojang usually does.) I don't see why this issue should remain open.

Also, why create an issue on this project specifically? How about the other 50 I know of?

Wyvest commented 3 years ago

I think we should get this closed, @dreamhopping this isn't your issue and it doesn't affect you (unless you are a Mojang dev, and if you are [most likely not], then you aren't handling this how Mojang usually does.) I don't see why this issue should remain open.

Also, why create an issue on this project specifically? How about the other 50 I know of?

Even if dreamhopping isn't a Mojang dev, it's still a valid issue, and should be fixed.

stpidgamers commented 3 years ago

These are quite serious, the project should not have been open sourced in the first place. As an alternative, you can use something like mixins. https://github.com/SpongePowered/Mixin fuck mixins they bad

I think using mixins is better than a potential DMCA on your project, don't you? You can't say you don't like mixins when I can make a very good assumption that you actually haven't used mixins, and that you probably know nothing about respect :)

Bro, Why mixins? when I can edit 1 line of code with in a few seconds.

josephworks commented 3 years ago

LMFAO @cbyrneee I saw that.

Have you read any of the conversation above? Do that, and then you'll understand. I didn't open this issue for mindless 9 year old skids to not take it seriously 🤦

Go ahead and close the issue or smth, its prob not going to be fixed for this project. From what I've read, noone here is taking it seriously, and again, nothing will probably be done about it. If I were OxideWaveLength, I would probably have applied the wontfix tag lol.

AverageComet250 commented 3 years ago

@OxideWaveLength is taking this seriously and he should. I think that forge or fabric should be used instead of mixins cause mixins is something that's a nightmare.

Or architectury can be used.

caoimhebyrne commented 3 years ago

Go ahead and close the issue or smth, its prob not going to be fixed for this project. From what I've read, noone here is taking it seriously, and again, nothing will probably be done about it. If I were OxideWaveLength, I would probably have applied the wontfix tag lol.

This is a legal issue, not some sort of code bug. This repository could be DMCA'd by Mojang / Microsoft or Optifine at any time. You don't seem to understand that, @josephworks.

caoimhebyrne commented 3 years ago

@OxideWaveLength is taking this seriously and he should. I think that forge or fabric should be used instead of mixins cause mixins is something that's a nightmare.

Or architectury can be used.

Mixins isn't too bad, but I can see why people wouldn't want to use it. Making it a mod is a lot better, and as you said, architectury is a great idea also.

ghost commented 3 years ago

Your project is in active violation of the MCP license. You are not allowed to distribute the Minecraft source in any way as stated in the license

The license:

License and terms of use.
=========================

No warranties. If MCP does not work for you, or causes any damage, it's your problem. Use it at own risk.

You are allowed to:
- Use MCP to decompile the Minecraft client and server jar files.
- Use the decompiled source code to create mods for Minecraft.
- Recompile modified versions of Minecraft.
- Reobfuscate the classes of your mod for Minecraft.

You are NOT allowed to:
- Use MCP to do anything that violated Mojangs terms of use for Minecraft.
- Release Minecraft versions or modifications that allow you to play without having bought Minecraft from Mojang.
- Release modified or unmodified versions of MCP anywhere.
- Use any of MCPs scripts, tools or data files without explicit written permission.
- Make money with anything based on MCP (excluding Minecraft mods created by using MCP).
- Use MCP to create clients that are used for griefing or exploiting server bugs.
- Release the decompiled source code of Minecraft in any way.

Tagging relevant people: @SeargeDP

oh no we are so sorry i am so sorry for a dmca violation oh no!!!!!!!!!!!! i donot want be repoT i sori!!!!!!!!!!!

AverageComet250 commented 3 years ago

This is an issue can people stop acting like this is a joke.

ghost commented 3 years ago

This is an issue can people stop acting like this is a joke.

lol no

ghost commented 3 years ago

Go ahead and close the issue or smth, its prob not going to be fixed for this project. From what I've read, noone here is taking it seriously, and again, nothing will probably be done about it. If I were OxideWaveLength, I would probably have applied the wontfix tag lol.

This is a legal issue, not some sort of code bug. This repository could be DMCA'd by Mojang / Microsoft or Optifine at any time. You don't seem to understand that, @josephworks.

oh no why mojang not dmca optifoon if they not use mixin??!?!?!?!??!?!

caoimhebyrne commented 3 years ago

oh no why mojang not dmca optifoon if they not use mixin??!?!?!?!??!?! @AcaiBerii

OptiFine's code is not public, and they are distributing it in the correct way. This project is open source and redistributing Minecraft's source.

ghost commented 3 years ago

oh no why mojang not dmca optifoon if they not use mixin??!?!?!?!??!?! @AcaiBerii

OptiFine's code is not public, and they are distributing it in the correct way. This project is open source and redistributing Minecraft's source.

but u can dekompile and deobfuskate optifoon????

AverageComet250 commented 3 years ago

@OxideWaveLength please make this thread collaborators only