search

OxideWaveLength / Minecraft-Hack-BaseClient

This is a Minecraft Base Client
MIT License
309 stars 47 forks source link

[BUG REPORT] Full module settings implementation for List<String> not added yet. #85

Open ghost opened 3 years ago

ghost commented 3 years ago

Describe the bug When adding a setting of the type List, I cannot scroll through the settings on the TabGUI like I normally would for any other client using the same type of setting.

To Reproduce In a setup() method of a module, paste this code in:

List<String> modeVals = new ArrayList();
modeVals.add("java math");
modeVals.add("bhop");

moduleSettings.addDefault("mode", modeVals);

Expected behavior To be able to scroll through the list of String settings I added.

Screenshots If applicable, add screenshots to help explain your problem.
pain

Stack Trace Add the error stack trace, if any.

Versions:

Additional context Add any other context about the problem here.
pain

OxideWaveLength commented 3 years ago

Unfortunately the ClickGui that is currently released is not final or complete. I'm working on a re-design but it's taking longer than anticipated. It will be released in the near future, though

ghost commented 3 years ago

Unfortunately the ClickGui that is currently released is not final or complete. I'm working on a re-design but it's taking longer than anticipated. It will be released in the near future, though

can i merge my clickgui then? :trol:

OxideWaveLength commented 3 years ago

Have you made the whole thing yourself?

ghost commented 3 years ago

Have you made the whole thing yourself?

the "design" is new, but the entire base is skidded from yours :)

OxideWaveLength commented 3 years ago

Oh, then I don't see why not, just fork the repository and create a PR, I will look at it later today 😄

ghost commented 3 years ago

just a question: do you have a gitignore for mcp files?

or should i merge my gitignore too

OxideWaveLength commented 3 years ago

I don't, but it's not needed as the repository is inside of MCP's "minecraft" folder itself Should be at least

ghost commented 3 years ago

okay pr open