search

OxideWaveLength / Minecraft-Hack-BaseClient

This is a Minecraft Base Client
MIT License
310 stars 47 forks source link

Commit ClickGUI/ArrayList Updates #86

Closed ghost closed 3 years ago

ghost commented 3 years ago

Delicious ZeroDay b21 colored ClickGUI

Content contained in issue #85
committed this bc oxidewavelength said so :)))

OxideWaveLength commented 3 years ago

I did notice there were a bit too many files, as Joseph pointed out. I'm not sure why this could be, but I think a way of fixing it would be to delete this PR and the fork, then re-fork again, add "minecraft/net" to the gitignore and commit. Then add your changes to the client, commit again and remove "minecraft/net" from the gitignore. Unless you have also made changes to Minecraft's source for the Gui

ghost commented 3 years ago

I did notice there were a bit too many files, as Joseph pointed out. I'm not sure why this could be, but I think a way of fixing it would be to delete this PR and the fork, then re-fork again, add "minecraft/net" to the gitignore and commit. Then add your changes to the client, commit again and remove "minecraft/net" from the gitignore. Unless you have also made changes to Minecraft's source for the Gui

I have made changes to Minecraft's source for the Gui by making it extend EventListener.

Everything else, I don't understand I guess?
I'll try fixing this.

josephworks commented 3 years ago

If you saw my deleted comment, I deleted it cause it was it was poorly worded and aggressive. however, I read over the commit changes and realized that there were simply way too many files added besides just a GUI, which didn’t match with the PR description. It would probably be easier to fix this issue with a software like gitkraken, this would be very difficult to do with GitHub desktop.

ghost commented 3 years ago

If you saw my deleted comment, I deleted it cause it was it was poorly worded and aggressive. however, I read over the commit changes and realized that there were simply way too many files added besides just a GUI, which didn’t match with the PR description. It would probably be easier to fix this issue with a software like gitkraken, this would be very difficult to do with GitHub desktop.

I'm now using SourceTree.

Should I still use GitKraken though? I've used it before, not a fan.

josephworks commented 3 years ago

I personally use it and it's pretty nice. I've never used sourcetree.