Closed ghost closed 2 years ago
This does fix the previous pr to an extent but I saw a few issues
Please fix this
okay okay sorry
done
should i gitignore /minecraft though or keep duplicates?
bc my original was to ignore the duplicate /minecraft folder
I don’t quit understand, if you gitignore that directory, then no changes made to it will pop up to be added and pushed. Why would you do that?
Also, I see that there are 3000 changes. The changes won’t even load in on my school iPad. Why are there so many?
Update: I found the issue
you refactored the Minecraft folder to src/minecraft, don’t do that.
please undo, or create a different PR to talk about that and apply your change.
Update: I found the issue
you refactored the Minecraft folder to src/minecraft, don’t do that.
please undo, or create a different PR to talk about that and apply your change.
YOU SAID UNGITIGNORE THE SRC LOLOLOLOL SO I DID IT
also the default mcp dir is src/minecraft so i moved everything there and once i was ready to push everything i copied minecraft from src/minecraft to the minecraft dir LOL
and no we dont do a little refactoring thats just how mcp does it
sorry for my munky brain
im reignoring /src if u dont want to 300000 changes LOL
Do not reignore/commit/push src/
It is not relevant to this project and could cause issues down the line.
You need to manually stage your changes and push them. Adding something to the Gitignore cause it fixes your auto-staging isn't good and healthy for this project.
Then do you not want the 300k changes or do you want me to regitignore? I might as well ditch this altogether.
I'm following the "same formatting" wavelength has, with one minecraft/ folder and no src/ in sight.
You are forgetting there is a middle-ground. You need to manually stage the changes you want to push.
Oxid's convention is to not have src/ or gitignore src/ and you are not following that.
Are you auto-staging btw?
1: Ok
2: I need to remove MCP then so I can't test it and see what's gone wrong without having an extra project
3: Yes I am with git add --all
and using the gitignore
3: Yes I am with git add --all and using the gitignore
I figured that was the case, that's not PRacceptable.
3: Yes I am with git add --all and using the gitignore
I figured that was the case, that's not PRacceptable.
"I fixed it"(TM)
I am now using notepad for my "IDE"
woops
Ok, yay! this is good @OxideWaveLength
Holy s**(shit) finally WOOOOO
Yay!
Glad to see you worked it out! It's getting a bit late here, first thing I'll do in the morning is clone and test your PR out! 👍
Alright. New features I've added and I'm assuming works (I removed MCP so I can no longer test it)
Getting late here too. Good night 🌙
What's the status on the pr?
hello?
I'm having some issues with the ClickGui, namely the categories can only be moved horizontally. I've also had a look at the file changes and some things go over just the ClickGui and I will consider making those go through. If you could fix the ClickGui I could then revert some changes and create a branch for this your modified ClickGui and ArrayList
I'm trying to patch this, but all my solutions either vertically glitch the categories, or just make the categories just float to the bottom.
I might just completely remove scrolling.
I made a makeshift "fix", it should work. Try again now.
Everything should be fixed now!
(also, insane gui rework <3)
I'm having some issues with the ClickGui, namely the categories can only be moved horizontally. I've also had a look at the file changes and some things go over just the ClickGui and I will consider making those go through. If you could fix the ClickGui I could then revert some changes and create a branch for this your modified ClickGui and ArrayList
1: Fixed
2: Gamer
3: Also the TabGui was changed dont forget about that :trollface:
4: Also changed the title to match what was in the PR.
@josephworks good to merge again? Are there any issues I should fix?
I don’t see any issues with the code, but we will have to wait for @OxideWaveLength to do testing.
No problem, do not worry about codacy, I already checked the issue with class conventions and I disregarded them, so you can too. Maybe @OxideWaveLength can review and update codacy settings later.
yeah don’t worry, I’m at school and I also amnt reading anything atm.
Oh, also I cannot test from here as I only have an iPad.
@josephworks here are previews with everything working (both flat and gradient shown where necessary) if you can't test
hosted on ImgBox because gamer. Everything has basically the same controls except the ClickGUI which you now can scroll with your mouse wheel like Future client. (what else would you use to scroll?)
tabgui
category tabgui
category tabgui, flat
rainbow tabgui
rainbow tabgui, flat
Offset setting is for offsetting the rainbow's "index" when scrolling through tabs.
clickgui
category clickgui
category clickgui, flat
rainbow clickgui
rainbow clickgui, flat
The ClickGUI rainbow is affected if you click and drag on it, kinda messes it up sorry
arraylist
category arraylist
category arraylist, flat
rainbow arraylist
rainbow arraylist, flat
The ArrayList also has an option where the tab color matches the module color if you don't like the pog java math put into the tabs
tabgui name change command
category namechange
rainbow namechange
Use this with .clientname {name}, you can't use spaces or it will only use the first word
Still any updates @OxideWaveLength @josephworks ?
Pr hasn't been merged for a while, fixed all errors mentioned by Oxide.
I'm still awaiting a response for the PR's status.
@OxideWaveLength help
Still no response?
Do you have contact with Oxide?
Still waiting for an update or merge...
I'll close this in a week if there's no response.
when merge
when merge
i have no idea whatsoever
3 days before close btw, probably won't get a response :)
if you want the update at all (me when no response in a week), use my branch.
1 more day until close
yup
i wont delete my branch tho if i want to ig i can update my branch when v1 comes out
@josephworks @OxideWaveLength
yup
i wont delete my branch tho if i want to ig i can update my branch when v1 comes out
@josephworks @OxideWaveLength
I made a pull request on your fork
Alr, time to delete this PR. If you want my fork, go to:
https://github.com/AcaiBerii/Minecraft-Hack-BaseClient
@OxideWaveLength yeah, you need to get your act together. Cloning, testing, and PRing doesn’t take much time and @AcaiBerii put even more time into his work compared to how long it will take to review and accept. You seriously wronged him by not getting to the PR in reasonable time.
@AcaiBerii I don’t see any reason for you to close the PR. If I was you I would leave a message giving a reason on why you will not continue putting effort into this PR and leave it as-is.
A am very disappointed to see a Pull Request end up like this. This isn’t right and shouldn’t of happened.
I don't feel like needing to leave open a PR like this just for it to go completely unnoticed and unmerged by Oxide, with no response for over 2 weeks.
I'll reopen this if you want, but it's really unnecessary if I don't at least get some activity on this.
:(
85