Allow theme customization from Android 12 onwards - Githubissues

OxygenCobalt / Auxio

A simple, rational music player for android

GNU General Public License v3.0

2.18k stars 147 forks source link

Allow theme customization from Android 12 onwards #131

Closed KraXen72 closed 2 years ago

KraXen72 commented 2 years ago

Describe the feature you want to implement:

auxios theme picker is really good and has a lot of themes. so why hide it on android 12 and up? Please show the theme picker even on android 12 and up.

Is your feature request related to a problem? Please describe:

I'm on a samsung device where material you is implemented very roughly so far, basically no real options and the palette is not respecting the wallpaper almost at all. i really liked the brown auxio theme, but now that i updated to android12 i can no longer switch to it, im stuck with whatever samsung picks.

Due Diligence:

[x] I have read the Contribution Guidelines.
[x] I have read the Accepted Additions and Requests document.
[x] I have checked for this feature in the FAQ.

OxygenCobalt commented 2 years ago

Sounds reasonable. I use a pixel, so I never realized that OEMs would botch dynamic theming as bad as they did.

KraXen72 commented 2 years ago

i forgot to add, the ideal workflow would be like this:

android < 12: user only seems theme selector
android => 12: (either of these)
- user sees modified theme selector with new option: dynamic/material you
- user sees unmodified theme selector and a setting to use material you theming (which overrides and hides theme selector as long as active)

OxygenCobalt commented 2 years ago

Yeah, I'm going for a new accent option, since dynamic colors work just like any other accent.

KraXen72 commented 2 years ago

coolio. only problem with that, maybe i'm recalling incorrectly, didn't the theme picker have an exact grid of items? like all rows and columns full. adding the material you will make a new row just for 1 color.

OxygenCobalt commented 2 years ago

The grid is adaptive. I'm fine with adding a new row, as the accent picker has been uneven in the past.

KraXen72 commented 2 years ago

~~well, well, well, isn't that the perfect oportunity to add more themes to fill it in~~ jk. cool, thanks.

OxygenCobalt commented 2 years ago

I wish, haha. Sadly the utility I use to make new themes either produces really ugly themes for new colors, or produces themes are too similar to existing themes (This was why deep orange and blue grey themes were removed). Material You is a big stickler about making themes as visible and accessible as possible.

OxygenCobalt commented 2 years ago

This will arrive in Auxio 2.3.0. Being able to deliberately override day/night themes will still be disabled though, as I deem Android 12 to be the first version in which having system-wide theme customization is a standard feature across all OEMs.