search

OxygenCobalt / Auxio

A simple, rational music player for android
GNU General Public License v3.0
2.03k stars 133 forks source link

Fix (& improve) repetition options #29

Closed Glitchy-Tozier closed 3 years ago

Glitchy-Tozier commented 3 years ago

Describe the bug:

This option (look at the left) probably does, what it should. It jumps to the next song when the current one is finished. The symbol is debatable, but otherwise it works fine: Screenshot_20210717-070933_Auxio.jpg

This symbol ALSO doesn't loop the song. It seems to work just as the first one does: Screenshot_20210717-071013_Auxio.jpg

This symbol loops the song forever (or at least 3 times) instead of just once. Screenshot_20210717-071024_Auxio.jpg

Sometimes people don't want to binge through their music, but instead only listen to one track and then have the playing stop until they want to listen to the next track. It can be annoying to immediately be bombarded with a different song. I suggest adding an option that lets the user play a song, and then pauses (and rewinds) the song when it's done playing.

Screenshots:

Screenshot_20210717-072414_Auxio.jpg

Phone Information:

Samsung Galaxy S9 Android 10

Due Diligence:

OxygenCobalt commented 3 years ago

Oh. After #13, Auxio's repeat modes are none, loop playlist, and loop forever. The second one didn't do anything since it would only repeat the playlist once it ended. If I understand correctly, you want the "Loop Forever" option to pause the song every time it loops? If that's the case, I can add a toggle for that behavior in the settings menu.

Glitchy-Tozier commented 3 years ago
  1. Yes, It would be great to see another option that rewinds and pauses the song after it's done.
  2. regarding the rest of your message, I'm not sure I fully understand your comment. Is there a difference between [black] and [blue]? (Let's call the third option "[blue 1]")
OxygenCobalt commented 3 years ago

Basically:

[black] - Loop the playlist, but pause when it loops [blue] - Loop the playlist, continuing playback when it loops [blue 1] - Loop the song forever.

I'll add an option to the "Behavior" part of the settings menu that toggles this change. It will still be represented as [loop 1], but instead of playing immediately after looping, it will just rewind and pause, like you said.

Glitchy-Tozier commented 3 years ago

Thank you for the explanation. The change you described sounds great, looking forward to using it! :)

Glitchy-Tozier commented 3 years ago

It could also be added as one of the regular options (it could be a pause icon or a pause icon inside the arrows), but if you prefer using the settings, that's fine too.

OxygenCobalt commented 3 years ago

I usually choose the settings for two reasons:

  1. Your preferred loop behavior tends to apply to a subset of users. I prefer keeping Auxio sensible by default and moving the quirks to the behavior menu, so thats where behavior additions tend to go. If theres sufficient demand for a dedicated mode for this specific behavior, it would likely be upgraded to one [as is what happened in #13].
  2. There's not a ready-made icon for such a mode, meaning that I would have to create my own. Not impossible [I did it with the sorting icons], but hard.
Glitchy-Tozier commented 3 years ago

Understood, lets go the settings-route then!