OxygenCobalt / Auxio

A simple, rational music player for android
GNU General Public License v3.0
1.8k stars 118 forks source link

Storage-based cover caching #327

Open OxygenCobalt opened 1 year ago

OxygenCobalt commented 1 year ago

Spun off from #104. More or less, Auxio could switch from it's current on-demand album cover system to a storage-cached album cover system. Images found when loading the library will be put into app storage and then retrieved whenever needed. This is already technically done by MediaStore, but with #322 jeopardizing access to their image cache (plus the generally garbage state of it's image cache), I'll likely need to build this myself.

The covers stored would be something like 1000x1000 (probably lower) in a currently undecided format. PNG will not be used since it's too bulky, and JPEG will not be used since it's terrible.

This has a few hypothetical benefits:

Possible drawbacks:

dmint789 commented 4 months ago

Please just don't make this reuse one album cover for all songs with missing covers. I've seen multiple music players that do this and it's very annoying.

OxygenCobalt commented 4 months ago

That won't be the case @dmint789. I'm not even sure how people end up end up designing a cover system that works like that.

OxygenCobalt commented 1 month ago

De-prioritizing since it's not needed.