OxygenCobalt / Auxio

A simple, rational music player for android
GNU General Public License v3.0
1.86k stars 122 forks source link

Fall back to grouping albums by common artists when album artist is not available #429

Open llamasblade opened 1 year ago

llamasblade commented 1 year ago

Description

If an album has different multiple artists in different songs but one artist is shared between every song (supposedly the main artist), then in the Albums view the album should be displayed as one single entry.

Problem solved

Currently an album with such properties is split into multiple albums in the Albums view, depending on the artists.

As an example I will use Dr. Dre's 2001 album. Every song has multiple artists, each with its own ARTIST tag. Each song also has the same ARTIST tag "Dr. Dre", who is the main artist of the album.

Currently the album is displayed this way (not the full album, but you get the idea).

Other implementations

I am aware that GoneMAD Music Player implements this feature, but since is it closed source I don't know how it does that.

Benefit

It makes sense that an album with a main artist is displayed as one single album and not multiple albums.

Duplicates

OxygenCobalt commented 1 year ago

This is working as intended. You need to add an Album Artist tag like "Dr. Dre" for Auxio to properly group the album. Auxio cannot rely solely on the album information, as if two artists have albums with the same name, they would be incorrectly interpreted as a single album.

llamasblade commented 1 year ago

I see, thank you and excuse me if this issue is redundant. The reason I've opened it is that similar issues did not specify that every song had the same artist tag, and also I did not have this problem on other players. But the way Auxio handles it definitely makes sense.

Thanks and excuse me again.

OxygenCobalt commented 1 year ago

Oh, I see. It might actually be possible to group albums by a set of shared artists, assuming there are no edge-cases. I'll look into it.

OxygenCobalt commented 1 year ago

I'll go re-open this to remind myself to investigate this proposed fallback eventually. I think it might be possible without insane edge cases, but it makes the music grouping logic a bit harder. Album artists will always take precedent however.

lriesebos commented 10 months ago

Hi, just ran into your app recently, I'm very impressed! Though this album artist issue is a thing for me too.

So this alternative music player does succeed in finding the main artist for an album and show that in the artist list accordingly (instead of having many duplicate entries in the artist list) https://github.com/SimpleMobileTools/Simple-Music-Player . Maybe their implementation could be an inspiration to get the feature implemented!

Edit: it seems I am mostly focused on the view in the artist list, while the issue is mostly about grouping albums for a common artist. while both issues are probably related, they are not exactly the same.

OxygenCobalt commented 10 months ago

Simple Music Player seemingly goes for the "blindly group by album" strategy, which is a non-starter since it mangles albums from different artists that have the same name. This implementation would be more complicated. I'd still highly recommend using the Album Artist tag @lriesebos.