search

OxygenCobalt / Auxio

A simple, rational music player for android
GNU General Public License v3.0
2.13k stars 141 forks source link

Make swiping down on the mini player stop playback #478

Open ryenyuku opened 1 year ago

ryenyuku commented 1 year ago

Description

It would be a nice little feature if you can stop the playback (and clear the queue) by just swiping down the mini player.

Problem solved

Swiping down the mini player will close it, clear the queue, and stop the playback.

Other implementations

My implementation on my currently dead music streaming app:

https://github.com/OxygenCobalt/Auxio/assets/59136093/71c42799-836e-4c5d-8eae-3911b59a1d0c

Benefit

This addition will allow user to easily clears queue and completely stop the playback without opening the notifications.

Duplicates

OxygenCobalt commented 1 year ago

I've been going back and forth on this, as while it's a good idea, I worry that stray swipes accidentally ending playback with no way to restore would be very user-unfriendly. I could make it a setting.

ryenyuku commented 1 year ago

Then I suggest to make it as an opt-in feature, some music players do this too (e.g. Retro).

OxygenCobalt commented 1 year ago

Another good thing about this is that it would force me to debug states where playback stops and then starts again. I forget to test this often since you have to trigger really obtuse states to do it, which then leads to regressions.

KraXen72 commented 1 year ago

i would be against this if it was not opt-in. it's one of the things that really annoys me about spotify mobile app, among other things.

etyarews commented 1 year ago

The issue with this is that the One Hand Mode gesture might be dangerously close to the mini player. With YouTube I sometimes trigger the one hand mode while trying to close a video

ryenyuku commented 1 year ago

The issue with this is that the One Hand Mode gesture might be dangerously close to the mini player. With YouTube I sometimes trigger the one hand mode while trying to close a video

Well, it doesn't need to be an opt-out or even a not turnoffable feature. Opt-in is enough.

etyarews commented 1 year ago

I speak more to bring the issue to light, rather than to discourage the feature to be implemented.

I'm not against the feature, but it only makes sense if it is designed and tested to prevent clashing with the one hand mode gesture. Even if it was opt-in, it should be well-designed, otherwise it might create headaches in the future.