search

OxygenCobalt / Auxio

A simple, rational music player for android
GNU General Public License v3.0
1.82k stars 120 forks source link

Add ability to change language #64

Open pavelsust opened 2 years ago

pavelsust commented 2 years ago

Can you please add language change feature into this application.

OxygenCobalt commented 2 years ago

That seems redundant. Can't one just change the system language?

pavelsust commented 2 years ago

That seems redundant. Can't one just change the system language?

You can add language change from the application.

OxygenCobalt commented 2 years ago

Is there a benefit for application-specific language configuration? I'm not too familiar with the state of Android for other languages.

ghost commented 2 years ago

«Panlingual» feature for per-app language settings planned for Android 13, so there is no point in adding this option to the app now.

OxygenCobalt commented 2 years ago

Sure, but version fragmentation fragmentation ensures that many people will not be on Android 13 for awhile. From what I've seen, a lot of non-native english speakers keep the system language as English because the translations are poor, but still enable their native language on an app-by-app basis. There might be some use in this.

OxygenCobalt commented 2 years ago

Update: I'll be adding this feature. Android 13 will be adding an API to set the app's locale, alongside some possible new androidx libraries that will handle the insane compatibility hacks on lower versions. I'll wait until the final release window to start working on this, so expect it to arrive in the summer.

OxygenCobalt commented 2 years ago

Judging by the new 1.6.0-alpha01 AppCompat Release, I can add this even sooner actually. Still no ETA since I'm quite busy, but it seems like an easy feature to add.

OxygenCobalt commented 2 years ago

Android 13 has hit platform stability, so I'm going to start working on this, and it should arrive in 2.5.0. However, I'm not sure whether the notification (or similar) will follow the in-app language or the system language, mostly due to possible technical complexity.

Edit: Not arriving in 2.5.0, feature is somewhat blocked by #129 and how to handle external strings like notifications

FEER0 commented 1 month ago

Is this still planned for a future update?

OxygenCobalt commented 5 days ago

Yes @FEER0, it's just very complicated since Auxio has to refresh the strings it exposes to the android system itself (like the MediaSession)