convert png files to webp to reduce apk size - Githubissues

OxygenCobalt / Auxio

A simple, rational music player for android

GNU General Public License v3.0

1.78k stars 117 forks source link

convert png files to webp to reduce apk size #724

Closed connyduck closed 2 months ago

connyduck commented 2 months ago

What is it?

[ ] Bugfix (user facing)
[ ] Feature (user facing)
[ ] Codebase improvement (dev facing)
[x] Meta improvement to the project (dev facing)

Description of changes

Converted png files to webp to reduce apk size
The conversion is lossless, the files look identical
release apk size before: 6864 kB
release apk size after: 6806 kB

APK testing

debug.zip

Due Diligence

[x] I have read the Contribution Guidelines.
[x] I have read the Why Are These Features Missing? page.

OxygenCobalt commented 2 months ago

Is this a valid thing to do? I'm hesitant to convert to webp since it might break on older android versions or OEMs @connyduck.

connyduck commented 2 months ago

It is not only a valid thing to do, it is the recommended thing to do. Lossless webps are supported since Android SDK 18. https://developer.android.com/studio/write/convert-webp

OxygenCobalt commented 2 months ago

Oh, I didn't know about this. This seems good then @connyduck.

OxygenCobalt commented 2 months ago

Can you sign your commits @connyduck?

connyduck commented 2 months ago

Looks like a hassle. Why?

OxygenCobalt commented 2 months ago

I've configured the repository to only allow signed commits to be merged.

OxygenCobalt commented 2 months ago

I generally like to maintain as much authenticity in commits as I can to maintain authenticity, given that I sign all of my commits.

OxygenCobalt commented 2 months ago

Thanks!