OxygenCobalt / Auxio

A simple, rational music player for android
GNU General Public License v3.0
1.78k stars 117 forks source link

Add option to disable lockscreen artwork #767

Closed HyperWinX closed 2 weeks ago

HyperWinX commented 3 weeks ago

Description

Most players, like AIMP or Namida has already implemented this switch. Namida developer did it pretty quickly after i asked him to do this, so its not that hard, i think. On some phones lockscreen artwork looks ugly, so its better to disable it.

Problem solved

Nuh uh~

Other implementations

AIMP and Namida have this switch, and some players too

Benefit

Lockscreen will be without ugly artwork.

Duplicates

OxygenCobalt commented 2 weeks ago

To do this means that you need to disable the cover uploaded to the app's media session, which breaks countless other things in modern android (notification, output switcher, etc.). It's an extremely short-sighted move to make, especially when most ROMs allow you to disable that functionality from what I'm aware.

HyperWinX commented 2 weeks ago

Just add warning that some things can break with disabled lockscreen artwork

OxygenCobalt commented 2 weeks ago

People don't read warnings or clarifications. They'll enable it, realize it breaks something else, and then make an issue without looking for duplicates or documentation or even reading any dialog I add for it. Everyone does this every once in awhile (even me), and it leads to a lot of unnecessary burden on me as a single maintainer.

Working on this is also a deeply slippery slope, as I've held my line on strictly conforming to what the android OS wants from me over allowing customization in the past. If I do this, then that justifies a bunch of other options that will also cause strange bugs and other conflicts which I would have to manage as a single maintainer. A lot of music apps succumb to this type of feature creep and I want to keep it at bay personally. I would rather keep the load light, especially when you can disable this in system settings from what I'm aware. Sorry.