Closed ericphanson closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
8fed3b9
) 98.31% compared to head (b7edf33
) 98.31%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think the test failure is unrelated, since I see it also on #160 which doesn't have any of the same changes as this PR, and I also see it in #158. I'm not sure what is causing it though 🤔
I noticed usage of
open
without the function-accepting form (see the Julia docs). This will open a file handle, but we never close them. It's good practice to close them, see e.g. https://stackoverflow.com/a/25070939Here I've done the minimal changes to remove unnecessary
open
calls for thing likeread
(which accept filepaths already), and in the other cases to use the form with a function as the first argument soopen
will close the handle for us.