Open ndortega opened 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.36%. Comparing base (
82fdc0e
) to head (d741ba5
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@JanisErdmanis Here's the changes you brought up
The test set looks good. Perhaps it could be improved with a case when package which depends on Oxygen is loaded as a module to check if there are any precompilation errors. I think that can be automated by creating a dummy package which can be put within a test directory and added to a LOAD_PATH which would then be treated as ordinary package with precompilation.
@ndortega can we also add a method:
get(collection, key) = Base.get(collection, key)
Since users or package developers may want to overload get
method this way. Perhaps even safer strategy here is:
get(args...) = Base.get(args...)
get(args...; kwargs...) = Base.get(args...; kwargs...)
We need to comment out in Oxygen.jl
with this pull request:
import Base: get
Because otherwise we have
import Base: get
get(x, y, z) = Base.get(x, y, z)
and thus if method is not found it would form a recursion. The removal of import Base: get
is also good as that eliminates type piracy.
An alternative is putting the redirection get
methods within the @oxidise
macro itself.