Ozon3Org / Ozon3

An open-source Python package to easily obtain real-time, historical, or forecasted air quality data for anywhere in the world. Reliable, accurate and simple.
GNU General Public License v3.0
66 stars 23 forks source link

When historical data output is saved as CSV file, the dates column is missing entirely, making the data hard to use #116

Closed Milind220 closed 2 years ago

Milind220 commented 2 years ago

Here's what the saved file looks like right now:

Screenshot 2022-04-20 at 4 27 21 PM

And the raw CSV file:

Screenshot 2022-04-20 at 4 27 33 PM

As you can see, there's no dates column, which would make this data confusing to work with

lahdjirayhan commented 2 years ago

We currently store the date information in the DataFrame's index (technically not a column). Maybe we shouldn't? Should we move the date information onto a column instead of the index? @Milind220

This index is also likely the cause of #114.

Milind220 commented 2 years ago

@lahdjirayhan I took a look at other air quality datasets, and they mostly do store date information in a column. I think it's a nice simple solution to fix this and #114 (if it is in fact the cause for that)

Milind220 commented 2 years ago

NOTE: Changing the dates information from the index to a column would also be regarded as a breaking change (I think). This is because the methods of querying the data would be different (columns vs index)