Ozon3Org / Ozon3

An open-source Python package to easily obtain real-time, historical, or forecasted air quality data for anywhere in the world. Reliable, accurate and simple.
GNU General Public License v3.0
66 stars 23 forks source link

[Breaking change]: Remove save data to file functionality #154

Closed Milind220 closed 2 years ago

Milind220 commented 2 years ago

Describe the change

Ozone offers some functionality to save data to CSV, Excel, or JSON files. However, this has introduced some messy code, a bug, and some very unintuitive ways of setting a save file name.

More importantly, we've realised that offering the functionality to save to a file Is unnecessary. A user could, with a single Pandas method (eg: dataframe.to_csv), save their data to a file themselves. This is also exactly what Ozone currently does anyway.

The proposed solution

Note: This was mentioned in 'option 1' of the comment by @lahdjirayhan in https://github.com/Milind220/Ozone/issues/151#issuecomment-1120910517

To remove the file saving features entirely.

Milind220 commented 2 years ago

hold my beer, I got this