[Breaking Change]: Remove save file func

Ozon3Org / Ozon3

An open-source Python package to easily obtain real-time, historical, or forecasted air quality data for anywhere in the world. Reliable, accurate and simple.

GNU General Public License v3.0

66 stars 23 forks source link

[Breaking Change]: Remove save file func #159

Closed Milind220 closed 2 years ago

Milind220 commented 2 years ago

This PR will address the breaking change of removing the save to file functionality that Ozone currently offers.

Milind220 commented 2 years ago

Work that needs to be done:

[x] Modify tests to work with lack of save file feature.
[x] Re recording cassettes to make tests work

Milind220 commented 2 years ago

@lahdjirayhan I believe this PR is complete :) I'll check again tomorrow

lahdjirayhan commented 2 years ago

@Milind220

Looks good to me!

Could you also please update the README because I think there's an example that still shows data_format argument being used.

Milind220 commented 2 years ago

@lahdjirayhan Hey, any idea why the linter checks might be failing?

EDIT: nvm I think this next commit should fix that. flake8 lint was flagging an unused import (I think my pre-commit hooks weren't working - reinstalled them now)

Milind220 commented 2 years ago

Okay I'm trying to solve some merge conflicts lol - excuse me if this gets a little messy.

EDIT: Hopefully this fixed it hahaha