Ozon3Org / Ozon3

An open-source Python package to easily obtain real-time, historical, or forecasted air quality data for anywhere in the world. Reliable, accurate and simple.
GNU General Public License v3.0
66 stars 23 forks source link

breaking change:complete conversion from Ozone to Ozone3 #167

Closed iamnandhu closed 2 years ago

iamnandhu commented 2 years ago

changed every instance of Ozone and ozone in the package to Ozon3 and ozone3 respectively including file names, class names and in docs

iamnandhu commented 2 years ago

Hey, if you look at the issue title and description carefully, you can see that it says change all mentions of ozone to ozon3, not ozone3.

ozon3 is the name of this package on PyPI, and this issue aims to add uniformity to the rest of the package.

Could you make this change please?

could you brief it please? so am I to change mentions of ozone in docs and comments and not tamper with the source codes

Milind220 commented 2 years ago

Hey, if you look at the issue title and description carefully, you can see that it says change all mentions of ozone to ozon3, not ozone3. ozon3 is the name of this package on PyPI, and this issue aims to add uniformity to the rest of the package. Could you make this change please?

could you brief it please? so am I to change mentions of ozone in docs and comments and not tamper with the source codes

@iamnandhu Let me make this as clear as I can:

As of now, everything says ozone You changed everything to ozone3 It should be ozon3

ozone3 vs ozon3 - Don't add an 'e' at the end :)

This issue describes changing it EVERYWHERE. Source code, documentation, everything.

Milind220 commented 2 years ago

@iamnandhu Hey! If you're no longer available to finish this pull request, please let me know and I'll delete it

If you want to finish it, but still need help understanding what to do, I can explain it again :)