search

Ozon3Org / Ozon3

An open-source Python package to easily obtain real-time, historical, or forecasted air quality data for anywhere in the world. Reliable, accurate and simple.
GNU General Public License v3.0
66 stars 23 forks source link

Created Dockerfile & Python File for the Application #175

Closed RohanRusta21 closed 7 months ago

RohanRusta21 commented 10 months ago

Hi @Milind220 @Miller2014 @lahdjirayhan @AliShahpurwala @Tomiiwa @ShootGan ,

I have created Dockerfile & Respective python code files which helps us the application to be get executed using cli commands. I have used Docker so that anyone can easily spin up the API in light weight containers without worrying about the installations of any external & 3rd part libraries. I hope this contribution is useful and valuable for the application. Also I have updated the README.md file with the steps so that anyone can easily follow them and use the application.

Please Review & Approve it :)

Thanks, Rohan

Milind220 commented 7 months ago

@RohanRusta21 Hey Rohan, I've reviewed your PR. Unfortunately, I don't think that dockerizing Ozon3, which is intended to be used simply as a Python library, is a good idea or helpful to the people who use it. As such I've decided to not merge your PR.

Thank you anyways for putting in the effort to make the PR.