search

Ozon3Org / Ozon3

An open-source Python package to easily obtain real-time, historical, or forecasted air quality data for anywhere in the world. Reliable, accurate and simple.
GNU General Public License v3.0
66 stars 23 forks source link

chore: add mypy linter, black and flake8 as development dependencies #68

Closed Samxx97 closed 2 years ago

lahdjirayhan commented 2 years ago

Nice!

Wouldn't it be best to also add a .flake8 file? (or other flake config setting, really) Especially because using black and flake8 requires a little setting to work in tandem, see here.

Maybe can be done in another PR, though.

Samxx97 commented 2 years ago

@lahdjirayhan indeed you are correct , I was thinking of doing this as the next step by taking example of this famous pipeline which also makes use of pre commit hooks as detailed here , but yeah this will have to be done in another pull request which will also address issue #54

Milind220 commented 2 years ago

Thanks @Sam-damn, and good idea @lahdjirayhan!