Oztechan / CCC

💰 Currency Converter Calculator for Android, iOS and Backend with power of Kotlin Multiplatform :muscle:
Apache License 2.0
310 stars 29 forks source link

[Oztechan/CCC#3585] Remove SelectCurrencyFragment navigation result logic #3586

Closed mustafaozhan closed 3 weeks ago

mustafaozhan commented 3 weeks ago

Resolves Oztechan/CCC#3585

codacy-production[bot] commented 3 weeks ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: -19.66% :white_check_mark: 50.00%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (09d39db70222b5f1e40b85d8e00cc411c0fbbb7b) | 3303 | 1713 | 51.86% | | | Head commit (c878c986c86a3a2f08d8befaf76f882aab69887d) | 5869 (+2566) | 1890 (+177) | 32.20% (**-19.66%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#3586) | 2 | 1 | **50.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences


:rocket: Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
20.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.19%. Comparing base (09d39db) to head (c878c98). Report is 4 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3586 +/- ## =========================================== + Coverage 55.09% 55.19% +0.09% =========================================== Files 166 166 Lines 2975 2970 -5 Branches 440 440 =========================================== Hits 1639 1639 + Misses 1305 1300 -5 Partials 31 31 ``` [![Impacted file tree graph](https://app.codecov.io/gh/Oztechan/CCC/pull/3586/graphs/tree.svg?width=650&height=150&src=pr&token=Lenq2MZgM7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oztechan)](https://app.codecov.io/gh/Oztechan/CCC/pull/3586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oztechan) | [Files](https://app.codecov.io/gh/Oztechan/CCC/pull/3586?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oztechan) | Coverage Δ | | |---|---|---| | [...iewmodel/selectcurrency/SelectCurrencyViewModel.kt](https://app.codecov.io/gh/Oztechan/CCC/pull/3586?src=pr&el=tree&filepath=client%2Fviewmodel%2Fselectcurrency%2Fsrc%2FcommonMain%2Fkotlin%2Fcom%2Foztechan%2Fccc%2Fclient%2Fviewmodel%2Fselectcurrency%2FSelectCurrencyViewModel.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oztechan#diff-Y2xpZW50L3ZpZXdtb2RlbC9zZWxlY3RjdXJyZW5jeS9zcmMvY29tbW9uTWFpbi9rb3RsaW4vY29tL296dGVjaGFuL2NjYy9jbGllbnQvdmlld21vZGVsL3NlbGVjdGN1cnJlbmN5L1NlbGVjdEN1cnJlbmN5Vmlld01vZGVsLmt0) | `100.00% <100.00%> (ø)` | | | [...ontent/selectcurrency/SelectCurrencyBottomSheet.kt](https://app.codecov.io/gh/Oztechan/CCC/pull/3586?src=pr&el=tree&filepath=android%2Fui%2Fmobile%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Foztechan%2Fccc%2Fandroid%2Fui%2Fmobile%2Fcontent%2Fselectcurrency%2FSelectCurrencyBottomSheet.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oztechan#diff-YW5kcm9pZC91aS9tb2JpbGUvc3JjL21haW4va290bGluL2NvbS9venRlY2hhbi9jY2MvYW5kcm9pZC91aS9tb2JpbGUvY29udGVudC9zZWxlY3RjdXJyZW5jeS9TZWxlY3RDdXJyZW5jeUJvdHRvbVNoZWV0Lmt0) | `0.00% <0.00%> (ø)` | |