Oztechan / CCC

💰 Currency Converter Calculator for Android, iOS and Backend with power of Kotlin Multiplatform :muscle:
Apache License 2.0
330 stars 29 forks source link

[Oztechan/CCC#3590] Remove CalculatorFragment navigation result logic #3595

Closed mustafaozhan closed 3 months ago

mustafaozhan commented 3 months ago

Resolves Oztechan/CCC#3590

codacy-production[bot] commented 3 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: -19.68% :white_check_mark: 0.00%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (6a46d24b1db7c54d75c001f365772d6a0d2659af) | 3298 | 1713 | 51.94% | | | Head commit (adb12b1b8768562e779d26c255ca958f6d2ad7fc) | 5859 (+2561) | 1890 (+177) | 32.26% (**-19.68%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#3595) | 1 | 0 | **0.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences


:rocket: Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.37%. Comparing base (6a46d24) to head (adb12b1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3595 +/- ## =========================================== + Coverage 55.19% 55.37% +0.19% =========================================== Files 166 166 Lines 2970 2960 -10 Branches 440 439 -1 =========================================== Hits 1639 1639 + Misses 1300 1291 -9 + Partials 31 30 -1 ``` [![Impacted file tree graph](https://app.codecov.io/gh/Oztechan/CCC/pull/3595/graphs/tree.svg?width=650&height=150&src=pr&token=Lenq2MZgM7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oztechan)](https://app.codecov.io/gh/Oztechan/CCC/pull/3595?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oztechan) | [Files](https://app.codecov.io/gh/Oztechan/CCC/pull/3595?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oztechan) | Coverage Δ | | |---|---|---| | [...ui/mobile/content/calculator/CalculatorFragment.kt](https://app.codecov.io/gh/Oztechan/CCC/pull/3595?src=pr&el=tree&filepath=android%2Fui%2Fmobile%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Foztechan%2Fccc%2Fandroid%2Fui%2Fmobile%2Fcontent%2Fcalculator%2FCalculatorFragment.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oztechan#diff-YW5kcm9pZC91aS9tb2JpbGUvc3JjL21haW4va290bGluL2NvbS9venRlY2hhbi9jY2MvYW5kcm9pZC91aS9tb2JpbGUvY29udGVudC9jYWxjdWxhdG9yL0NhbGN1bGF0b3JGcmFnbWVudC5rdA==) | `0.00% <ø> (ø)` | | | [...ui/mobile/content/currencies/CurrenciesFragment.kt](https://app.codecov.io/gh/Oztechan/CCC/pull/3595?src=pr&el=tree&filepath=android%2Fui%2Fmobile%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Foztechan%2Fccc%2Fandroid%2Fui%2Fmobile%2Fcontent%2Fcurrencies%2FCurrenciesFragment.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oztechan#diff-YW5kcm9pZC91aS9tb2JpbGUvc3JjL21haW4va290bGluL2NvbS9venRlY2hhbi9jY2MvYW5kcm9pZC91aS9tb2JpbGUvY29udGVudC9jdXJyZW5jaWVzL0N1cnJlbmNpZXNGcmFnbWVudC5rdA==) | `0.00% <0.00%> (ø)` | |