Oztechan / CCC

💰 Currency Converter Calculator for Android, iOS and Backend with power of Kotlin Multiplatform :muscle:
Apache License 2.0
305 stars 29 forks source link

[Oztechan/CCC#3638] Add back navigation result logic #3639

Closed mustafaozhan closed 1 week ago

mustafaozhan commented 1 week ago

Resolves Oztechan/CCC#3638

codacy-production[bot] commented 1 week ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: -0.43% :white_check_mark: 6.67%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (7bfad493fa4e9299aaa12a85057c3c892dfe7faa) | 3269 | 1776 | 54.33% | | | Head commit (ea6f89ed97fb53831f82553dfe1815d13092f980) | 3293 (+24) | 1775 (-1) | 53.90% (**-0.43%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#3639) | 30 | 2 | **6.67%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences


:rocket: Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 6.66667% with 28 lines in your changes missing coverage. Please review.

Project coverage is 57.30%. Comparing base (7bfad49) to head (ea6f89e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3639 +/- ## =========================================== - Coverage 57.80% 57.30% -0.50% =========================================== Files 166 166 Lines 2941 2965 +24 Branches 431 435 +4 =========================================== - Hits 1700 1699 -1 - Misses 1215 1240 +25 Partials 26 26 ``` [![Impacted file tree graph](https://app.codecov.io/gh/Oztechan/CCC/pull/3639/graphs/tree.svg?width=650&height=150&src=pr&token=Lenq2MZgM7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oztechan)](https://app.codecov.io/gh/Oztechan/CCC/pull/3639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oztechan) | [Files](https://app.codecov.io/gh/Oztechan/CCC/pull/3639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oztechan) | Coverage Δ | | |---|---|---| | [.../ccc/client/viewmodel/calculator/CalculatorSEED.kt](https://app.codecov.io/gh/Oztechan/CCC/pull/3639?src=pr&el=tree&filepath=client%2Fviewmodel%2Fcalculator%2Fsrc%2FcommonMain%2Fkotlin%2Fcom%2Foztechan%2Fccc%2Fclient%2Fviewmodel%2Fcalculator%2FCalculatorSEED.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oztechan#diff-Y2xpZW50L3ZpZXdtb2RlbC9jYWxjdWxhdG9yL3NyYy9jb21tb25NYWluL2tvdGxpbi9jb20vb3p0ZWNoYW4vY2NjL2NsaWVudC92aWV3bW9kZWwvY2FsY3VsYXRvci9DYWxjdWxhdG9yU0VFRC5rdA==) | `100.00% <ø> (ø)` | | | [...client/viewmodel/calculator/CalculatorViewModel.kt](https://app.codecov.io/gh/Oztechan/CCC/pull/3639?src=pr&el=tree&filepath=client%2Fviewmodel%2Fcalculator%2Fsrc%2FcommonMain%2Fkotlin%2Fcom%2Foztechan%2Fccc%2Fclient%2Fviewmodel%2Fcalculator%2FCalculatorViewModel.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oztechan#diff-Y2xpZW50L3ZpZXdtb2RlbC9jYWxjdWxhdG9yL3NyYy9jb21tb25NYWluL2tvdGxpbi9jb20vb3p0ZWNoYW4vY2NjL2NsaWVudC92aWV3bW9kZWwvY2FsY3VsYXRvci9DYWxjdWxhdG9yVmlld01vZGVsLmt0) | `99.35% <100.00%> (-<0.01%)` | :arrow_down: | | [...iewmodel/selectcurrency/SelectCurrencyViewModel.kt](https://app.codecov.io/gh/Oztechan/CCC/pull/3639?src=pr&el=tree&filepath=client%2Fviewmodel%2Fselectcurrency%2Fsrc%2FcommonMain%2Fkotlin%2Fcom%2Foztechan%2Fccc%2Fclient%2Fviewmodel%2Fselectcurrency%2FSelectCurrencyViewModel.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oztechan#diff-Y2xpZW50L3ZpZXdtb2RlbC9zZWxlY3RjdXJyZW5jeS9zcmMvY29tbW9uTWFpbi9rb3RsaW4vY29tL296dGVjaGFuL2NjYy9jbGllbnQvdmlld21vZGVsL3NlbGVjdGN1cnJlbmN5L1NlbGVjdEN1cnJlbmN5Vmlld01vZGVsLmt0) | `100.00% <100.00%> (ø)` | | | [...ui/mobile/content/currencies/CurrenciesFragment.kt](https://app.codecov.io/gh/Oztechan/CCC/pull/3639?src=pr&el=tree&filepath=android%2Fui%2Fmobile%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Foztechan%2Fccc%2Fandroid%2Fui%2Fmobile%2Fcontent%2Fcurrencies%2FCurrenciesFragment.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oztechan#diff-YW5kcm9pZC91aS9tb2JpbGUvc3JjL21haW4va290bGluL2NvbS9venRlY2hhbi9jY2MvYW5kcm9pZC91aS9tb2JpbGUvY29udGVudC9jdXJyZW5jaWVzL0N1cnJlbmNpZXNGcmFnbWVudC5rdA==) | `0.00% <0.00%> (ø)` | | | [...ontent/selectcurrency/SelectCurrencyBottomSheet.kt](https://app.codecov.io/gh/Oztechan/CCC/pull/3639?src=pr&el=tree&filepath=android%2Fui%2Fmobile%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Foztechan%2Fccc%2Fandroid%2Fui%2Fmobile%2Fcontent%2Fselectcurrency%2FSelectCurrencyBottomSheet.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oztechan#diff-YW5kcm9pZC91aS9tb2JpbGUvc3JjL21haW4va290bGluL2NvbS9venRlY2hhbi9jY2MvYW5kcm9pZC91aS9tb2JpbGUvY29udGVudC9zZWxlY3RjdXJyZW5jeS9TZWxlY3RDdXJyZW5jeUJvdHRvbVNoZWV0Lmt0) | `0.00% <0.00%> (ø)` | | | [...ui/mobile/content/calculator/CalculatorFragment.kt](https://app.codecov.io/gh/Oztechan/CCC/pull/3639?src=pr&el=tree&filepath=android%2Fui%2Fmobile%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Foztechan%2Fccc%2Fandroid%2Fui%2Fmobile%2Fcontent%2Fcalculator%2FCalculatorFragment.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oztechan#diff-YW5kcm9pZC91aS9tb2JpbGUvc3JjL21haW4va290bGluL2NvbS9venRlY2hhbi9jY2MvYW5kcm9pZC91aS9tb2JpbGUvY29udGVudC9jYWxjdWxhdG9yL0NhbGN1bGF0b3JGcmFnbWVudC5rdA==) | `0.00% <0.00%> (ø)` | | | [...echan/ccc/android/ui/mobile/util/ViewExtensions.kt](https://app.codecov.io/gh/Oztechan/CCC/pull/3639?src=pr&el=tree&filepath=android%2Fui%2Fmobile%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Foztechan%2Fccc%2Fandroid%2Fui%2Fmobile%2Futil%2FViewExtensions.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oztechan#diff-YW5kcm9pZC91aS9tb2JpbGUvc3JjL21haW4va290bGluL2NvbS9venRlY2hhbi9jY2MvYW5kcm9pZC91aS9tb2JpbGUvdXRpbC9WaWV3RXh0ZW5zaW9ucy5rdA==) | `0.00% <0.00%> (ø)` | |
sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
4.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud