search

Ozu-Beatmap-Toolset / ozu-cli

A cli app to help with Osu! beatmap creation
0 stars 0 forks source link

Fix slider tail rescaling when note-snapping sliders #7

Closed PladsElsker closed 2 years ago

PladsElsker commented 2 years ago

It seems like we are miscalculating the desired end time and/or the current end time of the slider tail

PladsElsker commented 2 years ago

Ah, found an issue.

We only multiply by the beatMap slider velocity when the green line is after the red line.

We need to ALWAYS multiply by the beatmap's slider velocity (the one in the timing tab yes).

Pretty sure this is not gonna solve everything, but at least we can fix that

PladsElsker commented 2 years ago

Found the other issue. We needed to take into account the whole slider length (with the repeats) and calculate its true length with that.

Now it should be fixed.