search

OzymandiasTheGreat / mopidy-ytmusic

Mopidy extension for playling music/managing playlists in Youtube Music
Apache License 2.0
80 stars 28 forks source link

Support for latest ytmusicapi #68

Open fabaff opened 2 years ago

fabaff commented 2 years ago

ytmusicapi was released as 0.24.0 a couple of days ago with some breaking changes.

A quick search in the source showed that get_playlist_suggestions and get_watch_playlist_shuffle are not used.

Currently there is a constraint present ytmusicapi>=0.22.0,<0.23.0 which will break packages shipped by distributions when they update ytmusicapi.

Any chance to get support for 0.24.0?

Thanks.

cprn commented 1 year ago

Already happened for Manjaro (which is 2 weeks behind Arch so it's safe to say it's broken for Arch as well):

Disabled extension ytmusic: ytmusicapi<0.23.0,>=0.22.0 required, but found ytmusicapi 0.24.0 at /usr/lib/python3.10/site-packages

As a workaround you can install older version manually, e.g.:

pip install ytmusicapi==0.22.0
impliedchaos commented 1 year ago

I've widened the version requirements for ytmusicapi, so this should be fixed with 0.3.8.

cprn commented 1 year ago

Works fine with 0.24.0 and 0.25.0 (current - just updated).

jclds139 commented 1 year ago

At this point with 1.0 and up released there's new authentication workflow as well (it can do proper OAuth now!). So, what will it take to get updated to that?

jmcdo29 commented 1 year ago

I've got a basic PR in that makes ytmusicapi >= 1.0.0 work, but nothing about supporting OAuth yet PR now supports OAuth too. I'm not sure well versed in python so I didn't dive much into getting that part working, just wanted to fix it on my Arch system

cprn commented 1 year ago

71 can be marked as duplicate of this issue. Then only thing worth mentioning: if you want to run mopidy-ytmusic before this PR is accepted you'll have to:

pip uninstall ytmusicapi
pip install ytmusicapi==0.25.2
pip install pytube==12.1.0
shad-lp commented 11 months ago

It could really be nice that this project lives again, since oAuth is officially supported. The expiring auth credentials were so annoying I had given up on Mopidy-YTMusic. There is a PR #73 waiting for this awesome software to become usable again.