search

P-H-C / phc-winner-argon2

The password hash Argon2, winner of PHC
Other
4.78k stars 406 forks source link

Unused last_node field, possibly old leftover code #358

Closed moneromooo-monero closed 1 year ago

moneromooo-monero commented 1 year ago

last_node is unused, it's tested in blake2b_set_lastblock. AFAICT it's only ever set to 0 implicitely in the state init, so blake2b_set_lastnode never gets called. It's public so it may be that the API user has to set it but git grep shows no reference to it so seems unlikely.

moneromooo-monero commented 1 year ago

Well, some python lib seems to use it as API input, so I guess it actually is, just not documented. Closing then.