P0mf / Handy-mpv

simple handy connect script player.
5 stars 1 forks source link

How do I select the video file? Any missing features? #2

Open Aguy1724 opened 1 year ago

Aguy1724 commented 1 year ago

I see the note to run the script when you run the python command. Is there a way to indicate the video file or is it assuming a video file in the same folder??

Also, are there any missing features? I know some Python so may be able to do some work on this if there's anything worth adding.

fllthdcrb commented 1 year ago

(Note: I have no connection to this project. Just commenting.)

I see the note to run the script when you run the python command. Is there a way to indicate the video file or is it assuming a video file in the same folder??

Actually, it's the other way around. Despite what the readme says, the video file is what you specify as the argument. There is no way to specify the script; instead, it assumes you have it in the same directory with the same name as the video but the extension replaced by ".funscript". Adding an option to specify the script would be a good idea.

Also, are there any missing features? I know some Python so may be able to do some work on this if there's anything worth adding.

Perhaps implement adding a sync offset, analogous to the "Sync adjustment" slider on HandyFeeling, and letting the user adjust it during playback. I think this would entail using the /hstp/offset endpoint of the API.

Also remember: If the owner of this repo is unresponsive, forking is an option, as are later pull requests.