P0nk / Cosmic

MapleStory Global v83 server emulator
https://discord.gg/JU5aQapVZK
GNU Affero General Public License v3.0
388 stars 199 forks source link

Mushroom Kingdom - Prime Minister not spawning #204

Open P0nk opened 9 months ago

P0nk commented 9 months ago

"(...) in the Mush Kingdom the Prime Minister isn't spawning, the princess doesn't offer the interaction to spawn him either."

14:16:01.870 [nioEventLoopGroup-3-21] ERROR npc.NPCScriptManager - Error performing NPC script action for npc: 1300013 javax.script.ScriptException: java.lang.NullPointerException: Cannot invoke "Object.getClass()" because "list" is null at java.util.Collections.unmodifiableList(Collections.java:1319) ~[?:?] at net.server.world.Party.getEligibleMembers(Party.java:160) ~[classes/:?] at scripting.event.EventInstanceManager.registerParty(EventInstanceManager.java:364) ~[classes/:?] at scripting.event.EventManager.startInstance(EventManager.java:633) ~[classes/:?] at scripting.event.EventManager.startInstance(EventManager.java:589) ~[classes/:?] at scripting.event.EventManager.startInstance(EventManager.java:585) ~[classes/:?] at .action(:47) ~[?:?] at org.graalvm.polyglot.Value.execute(Value.java:880) ~[graal-sdk-22.2.0.jar:?]

yuzumika commented 9 months ago

For what it's worth, I was able to complete the entire Mushroom Kingdom questline by playing through it normally (including spawning the Prime Minister).

wejrox commented 1 month ago

tbh the error seems like they aren't in a party and the code isn't handling that case