Surprise Box Implementation

[channarit1994]

• Added showCashInventory after a successful gachapon opening in the CashShopSurpriseHandler.
• Added getItemsSize() condition to check the inventory size before proceeding with the cash shop surprise opening

Description

I have added the following line to show the cash inventory after a successful gachapon opening in the CashShopSurpriseHandler:

c.sendPacket(PacketCreator.showCashInventory(c));

This line is added within the condition where cssResult is not null, right after sending the success packet for the Surprise box open event. This ensures that the cash inventory is displayed to the user upon a successful operation.

and I have added the following condition to check the inventory size before proceeding with the cash shop surprise opening:

if (getItemsSize() >= 100) { return null; }

This line is added at the beginning of the openCashShopSurprise method. It ensures that if the inventory size is greater than or equal to 100, the method will return null and not proceed further. This prevents adding new items when the inventory is full.

Checklist before requesting a review

• [x] I have performed a self-review of my code
• [x] I have tested my changes
• [ ] I have added unit tests that prove my changes work

Screenshots

[channarit1994]

Looks fine. One downside with your solution is that the surprise item is shown prematurely in the inventory, but I suppose that's better than not updating the box count at all. It doesn't seem like the "remainingBoxes" integer in the packet does anything unfortunately.

If I found it, I will let you know and update it again.

Regards,