search

P1X-in / tanks-of-freedom-ii

Indie Turn Based Strategy in Isometric Voxel Art http://tof.p1x.in
Other
194 stars 19 forks source link

Refactored abilities to resources #26

Open GaidamakUA opened 1 month ago

GaidamakUA commented 1 month ago

I wanted to be able to easily edit units. And with resources it's possible to edit them as a table with ResourceTables addon. The end goal is to be able to edit everything about factions in a spreadsheet. What do you think?

czlowiekimadlo commented 1 month ago

Overall I like the approach, but this specific implementation has some issues. I'm yet to test it in the editor, but it looks like it destroys all defaults, all values are repeated in every resource file. This is going to be difficult to manage to someone without this addon, and I don't really like the idea of having mandatory addons. I can only assume that ability_resource.gd duplicating what ability.gd does is just a WIP. This follows my desired approach to use class_name but the names used are not appropriate. Having hero production ability use the Hero class name is going to be very confusing.

Would the intent be to change all abilities to be resources? As this concept encompasses also unit passives and actives.