P1X-in / tanks-of-freedom-ii

Indie Turn Based Strategy in Isometric Voxel Art http://tof.p1x.in
Other
221 stars 20 forks source link

Draft: Implemented loading bundled campaigns #4

Closed GaidamakUA closed 3 years ago

GaidamakUA commented 3 years ago

TODO: Probably, it's better to create bundled dictionary automatically @czlowiekimadlo What do you think?

czlowiekimadlo commented 3 years ago

Indeed, you could create bundled dictionary automatically using the Directory class, though that would require some more tinkering, as special-purpose maps would need to be separated, and additional metadata, like "online_id" would need to be moved into the map file itself.

GaidamakUA commented 3 years ago

@czlowiekimadlo Fixed issues, you've mentioned. Please, squash commits while merging and give it a good name. And sorry, screwed up history of map_loader.gd should've used merge and not rebase. You might want to reread map_manager.gd. Since we now have bundled field, I decided to add bundled maps directly to maps dictionary.

czlowiekimadlo commented 3 years ago

Thank you very much for your contribution!