P1sec / pycrate

A Python library to ease the development of encoders and decoders for various protocols and file formats; contains ASN.1 and CSN.1 compilers.
GNU Lesser General Public License v2.1
381 stars 132 forks source link

pycrate_asn1c.proc renamed to asnproc not reflected in wiki #182

Closed KenWhitesell closed 2 years ago

KenWhitesell commented 2 years ago

On the page https://github.com/P1sec/pycrate/wiki/Compiling-asn1-specifications, in the section on the pycrate_asn1c modules, the example still refers to pycrate_asn1c.proc instead of asnproc. Likewise, there's another such reference at https://github.com/P1sec/pycrate/wiki/Compiling-asn1-specifications#the-pycrate_asn1dir-directory to proc.py instead of asnproc.py.

I guess there's also a related question: Is there a way for a regular user (for example, me) to supply or submit edits for the wiki pages?

p1-bmu commented 2 years ago

Thanks for your feedback. I fixed the incorrect references. Regarding editing the wiki, I manage it as a git repo (see https://docs.github.com/en/communities/documenting-your-project-with-wikis/adding-or-editing-wiki-pages, where you can git clone https://github.com/P1sec/pycrate.wiki.git). However, I am not completely sure if it is possible to submit PR for it.