P1sec / pycrate

A Python library to ease the development of encoders and decoders for various protocols and file formats; contains ASN.1 and CSN.1 compilers.
GNU Lesser General Public License v2.1
381 stars 132 forks source link

IE "Created PDR" is not in the class PFCPSessionEstablishmentRespIEs #204

Closed markwangsm closed 2 years ago

markwangsm commented 2 years ago

Hi P1sec,

According to 3GPP TS 29.244 REL 16 "Interface between the Control Plane and the User Plane Nodes",IE "Created PDR" is in the PFCP Session Establishment Response ( TS 29.244 CH 7.5.3). But in your code "TS29244_PFCP.py" ,"Created PDR" changes to the "Create PDR" in class "PFCPSessionEstablishmentRespIEs" . It doesn't meet TS 29.244 . Can you check it ? Here is pycrtate latest code : ========== TS29244_PFCP.py v0.5========= class PFCPSessionEstablishmentRespIEs(PFCPIEs): MAND = { PFCPIEType.NodeID.value, PFCPIEType.Cause.value } OPT = { PFCPIEType.OffendingIE.value, PFCPIEType.FSEID.value, PFCPIEType.CreatePDR.value, PFCPIEType.LoadControlInformation.value, PFCPIEType.OverloadControlInformation.value, PFCPIEType.FQCSID.value, PFCPIEType.FailedRuleID.value, PFCPIEType.CreatedTrafficEndpoint.value, PFCPIEType.CreatedBridgeInfoforTSC.value, PFCPIEType.ATSSSControlParameters.value, PFCPIEType.RDSConfigurationInformation.value, PFCPIEType.PartialFailureInformationSessionEstablishmentResp.value }

p1-bmu commented 2 years ago

First of all, please do an effort to properly format your text when opening an issue. You are correct otherwise, and it's fixed in https://github.com/P1sec/pycrate/commit/505aca35296befca3229ad89f9a0b9f38156cdfd.