search

P1sec / pycrate

A Python library to ease the development of encoders and decoders for various protocols and file formats; contains ASN.1 and CSN.1 compilers.
GNU Lesser General Public License v2.1
380 stars 130 forks source link

Incorrect parsing function call in NASLTE_MT for inner ESM Container #224

Closed Marc-Egli closed 1 year ago

Marc-Egli commented 1 year ago

By reading through the decoding of Mobile Terminated NAS messages I found the following function call:

https://github.com/P1sec/pycrate/blob/5120eb20fede8f5c2e6115946b711f4a0074b029/pycrate_mobile/NASLTE.py#L280

I think for correctness it should call parse_NASLTE_MT and not parse_NASLTE_MO. I looked at both functions and I think this makes no difference as they are very similar and because an ESM container cannot contain an EMM message there is no risk of confusing EMM_MT and EMM_MO messages but it might become an issue in the future if the two functions start to differ more.

p1-bmu commented 1 year ago

Thanks for reporting. This should be fixed after the 2 last commits.

Marc-Egli commented 1 year ago

Thank you !