search

P1sec / pycrate

A Python library to ease the development of encoders and decoders for various protocols and file formats; contains ASN.1 and CSN.1 compilers.
GNU Lesser General Public License v2.1
381 stars 132 forks source link

OER/COER support #60

Closed JNevrly closed 3 years ago

JNevrly commented 5 years ago

Obviously this is not an issue, but is there a plan to support OER/COER in a near future?

p1-bmu commented 5 years ago

Currently, there is no plan to introduce a support of OER in pycrate. As this represent a large amount of work, and I have no need for it, I won't do it in my free time / in a near future. In case you absolutely need it and won't implement it yourself, you can contact my employer (https://www.p1sec.com/corp/) to request a commercial support for such development.

p1-bmu commented 4 years ago

Switching this as enhancement, but not expecting to work on it anytime soon.

JNevrly commented 4 years ago

So I've progressed with the OER/COER implementation, most of the common types are done, but I'm bit confused about the implementation of the TIME type. Not knowing much about ASN.1, this seems to be some new-ish type (since it's not mentioned in the old Dubuisson copy I have) and I don't see any support for it in the Pycrate. Is that observation correct? (I the OER/COER standard X.696 (08/2015), a significant portion is spent on the TIME type, so it looks like a big deal ;)). To simplify the question - is it OK to skip the TIME type implementation and go ahead with the PR?

p1-bmu commented 4 years ago

TIME was newly introduced in 2015 IIRC (together with OID-IRI and RELATIVE-OID-IRI), and seems quite complex also in BER/CER/DER. You can skip it as there is currently no support for it in pycrate, neither in the compiler nor in the runtime.

JNevrly commented 3 years ago

With PR #110 merged, I think this can be closed.