search

P20WCommunityOfInnovation / DAR-T

Apache License 2.0
3 stars 0 forks source link

Correcting error in concatenating string to list in validation checks #90

Closed sethltaylor closed 8 months ago

sethltaylor commented 8 months ago

The duplication check wasn't working properly when a single sensitive column was provided as a string and not a list. The new check starts an empty list and appends values to it as they exist to reduce repeated checking.

Closes #89

VT-AOE-DMAD-Drew-Bennett commented 8 months ago

I am concerned with pushing develop to main. Can we push to a new develop branch or push to main for the time being?

sethltaylor commented 8 months ago

I am concerned with pushing develop to main. Can we push to a new develop branch or push to main for the time being?

@VT-AOE-DMAD-Drew-Bennett Can you clarify the concern with pushing develop to main again? If we have a feature like Beth's code that we're holding off on working on for now can we pull it to its own feature branch so we retain it and then eventually merge it back up into develop and then to main when it's finished?

I just think consistently pushing to main or pushing to a secondary develop branch will get messy.

Let's toss this discussion in the developer chat so we can get Garret and Nathan's thoughts as well.