Peer alias over video and fix black screen

P2PSP / Virtual-Room

A virtual room where friends share videos among them in real time directly over the web browser, with synchronized playback and a video chat at the same time.

GNU General Public License v3.0

34 stars 25 forks source link

Peer alias over video and fix black screen #25

Closed jainamritanshu closed 7 years ago

jainamritanshu commented 7 years ago

I have made the following changes -

Fixed breaking of URL on clicking copy to clipboard
Added peer alias name over video element
Replaced the black screen with avatar on turning off webcam(for other peers)

cristobalmedinalopez commented 7 years ago

Hi @jainamritanshu,

Just a little detail, when you change the alias in a peer, the name is not replaced under the video element, it is added instead. Could you check it?

Thanks!

jainamritanshu commented 7 years ago

Hi @cristobalmedinalopez, my bad I couldn't test the PR properly after deleting duplication of alias. I have updated the PR, and it works fine now I guess, kindly have a look :smile:

cristobalmedinalopez commented 7 years ago

It works fine now. Thanks!