P2PSP / Virtual-Room

A virtual room where friends share videos among them in real time directly over the web browser, with synchronized playback and a video chat at the same time.
GNU General Public License v3.0
34 stars 25 forks source link

Synchronized playback fixed in reference to issue #7 #9

Closed jainamritanshu closed 7 years ago

jainamritanshu commented 7 years ago

Hi, I have fixed the synchronized playback completely

cristobalmedinalopez commented 7 years ago

Hi @jainamritanshu, It doesn't work properly for me yet. Play action is received for every peer, however, it's not the same with the Pause action. Now, sender can pause the stream for everyone but peers can't. Please, Could you recheck it? Thanks!

jainamritanshu commented 7 years ago

Hi @cristobalmedinalopez I checked it again, unfortunately the onpause event doesn't return a promise like the onplay event so I couldn't possibly reset the event handlers properly. It seems to be resolved now, kindly check it :smile:

josmangarsal commented 7 years ago

Thanks! It works.