FR : ADS-Metadata - Length Constraints increase in TABLE, COLUMN and SCHEMA

P3-Core-Dev-Team / P3-Q-A

This repo is for tracking features

Other

1 stars 0 forks source link

FR : ADS-Metadata - Length Constraints increase in TABLE, COLUMN and SCHEMA #111

Open kilam005 opened 3 months ago

kilam005 commented 3 months ago

Problem Statement In Fairview we are encountering some columns with length more than 64 char. The current restriction of 64 characters prevents the metdata upload and app creation

Solution needed The length constraint should be adjusted to accomodate more characters

Alternatives / Consideration

the length constrains should be adjusted or kept configurable with ease
It should be applied for tables and schema along with columns
The UI length constraints on name for the corresponding fields should be adjusted
The UI display points should be consided or made be to be accomodative

Additional context Column list with more than 64 char:

Current schema validation file:

Error during ingestion:

KowsalyaChandran commented 3 months ago

RCA: column length limit was 64 Fix provided: Column length increased to 100 and raised PR . Once it's approved, will handover to testing team PR link : https://github.com/P3-Core-Dev-Team/ADS_BE/pull/2767

kilam005 commented 3 months ago

@KowsalyaChandran / @selvakumarchandran has it been handed over to testing?

KowsalyaChandran commented 3 months ago

@kilam005 PR got merged. It will be deployed in next release for testing.

KowsalyaChandran commented 3 months ago

@Udhayanila8 Fix is available in tag '2024.06.45459_RC1' and has been deployed in Rented test region. Please check.

kilam005 commented 2 months ago

@Udhayanila8 to verify and confirm

kilam005 commented 2 months ago

@Udhayanila8 the technical limitation was infromed about additing the constraint at table and schema level. So unless a real need come from a source, the requirment fulfliment at column level is sufficient.

kilam005 commented 2 months ago

Testing has started.

Udhayanila8 commented 2 months ago

_Server: 192.168.56.146 Version: 2024.07.45502RC2

Able to add columns with 100 character length. Added and uploaded metadata with 100 characters in the column Trigger schema-level ingestion Ingestion completed Able to create and perform searches COC report for that Ingestion report In query editor page

maheswarareddyi commented 2 months ago

The feature has been verified and will be rolled out in the next release.