P3-Core-Dev-Team / P3-Q-A

This repo is for tracking features
Other
1 stars 0 forks source link

FR : ADS-Global query editor-Query editor runs indefinitely. Fairview #133

Open ThulasiP3 opened 1 month ago

ThulasiP3 commented 1 month ago

Is your feature request related to a problem? Please describe. Query editor runs indefinitely in ADS .So for complex queries It is taking long time to respond.

Describe the solution you'd like Need a cancel option or restrict the result counts retrieved to a definite runs.

Describe alternatives you've considered We can use limit keyword in queries to restrict the counts retrieved until the feature is added

Additional context Add any other context or screenshots about the feature request here.

maheswarareddyi commented 1 month ago

@prabhakaranUI As discussed please plan your development based on the screen design shared and deliver the feature.

prabhakaranUI commented 1 month ago

@Nithya712 image

maheswarareddyi commented 1 month ago

Development has not yet started and is planned to start this week.

yadhubhushanreddy commented 1 month ago

@maheswarareddyi Is it possible to enable validate functionality along with cancel execution ? End user can at least validate the query if the execution is taking too long before proceeding for search screen configuration.

yadhubhushanreddy commented 1 month ago

I believe we're already validating the syntax in the current version. We're good for now by enabling the cancel execution feature.

kilam005 commented 1 month ago

FE side work is ready and awaiting BE team updates for integration. BE team estimated to complete by mid next week

maheswarareddyi commented 1 month ago

@selvakumarchandran Provide the enhancement deliverable status here

maheswarareddyi commented 1 month ago

@selvakumarchandran @ShaliniSettu Can you provide the ETA for this feature request.

ShaliniSettu commented 2 weeks ago

Phase 1: Disconnecting the API call from the frontend. Phase 2: Cancelling global query editor queries asynchronously in Trino.

@prabhakaranUI, could you please provide an ETA for Phase 1?

Nithya712 commented 2 weeks ago

@ShaliniSettu By the end of this week, it will be resolved.

Nithya712 commented 1 week ago

Development has been completed to this version [V_2024.09.45542]

image image image
kilam005 commented 1 week ago

@Nithya712 1) Hope the cancel option shows up after at least 5 second. 2) In the result screen the columns seems to miss padding. This is previously informed and correction was made. Can you double confirm.

prabhakaranUI commented 4 days ago

@ShaliniSettu / @selvakumarchandran
Phase 1 is ready https://github.com/P3-Core-Dev-Team/P3-Q-A/issues/133#issuecomment-2461382834 kindly update the phase 2 status

kilam005 commented 1 day ago

Phase 1 development is completed and release is already out. Phase 2 development is in progress and is tragetted for new release 2024.10.x