search

P3-Core-Dev-Team / P3-Q-A

This repo is for tracking features
Other
1 stars 0 forks source link

ADS - COC - Showing wrong report #148

Open suseela22 opened 1 month ago

suseela22 commented 1 month ago

Describe the bug

COC report is generated with datatype error message for the proper datatype. The datatype of the column is 'INTEGER' in the metadata but it still expects the column to be 'INTEGER'

Screenshots

image

image

image

Additional context Build no : 2024.09.45542 Region : http://192.168.1.218:408/

kilam005 commented 1 month ago

@Udhayanila8 please check this issue. Get the metdata and data used for checking.

kilam005 commented 1 month ago

Rerun testcases for all datatypes. ANd report issue back to dev team.

maheswarareddyi commented 3 weeks ago

@Udhayanila8 please validate the test cases as requested and provide the results of the testing. @abirami1994 Will start the development activities for this fix today.

suseela22 commented 3 weeks ago

Attaching the metadata, parquet file and COC report for reference Files_&_Report.zip

kilam005 commented 1 week ago

@abirami1994 and @Nadarajan-suyambu have given a patch fix. We have to check specific cases and will be checked by @ashoksri0 and taken for fulfilling complete fix.

abirami1994 commented 5 days ago

@kilam005 The fix was merged yesterday. @Udhayanila8 Need to verify this.

Udhayanila8 commented 5 days ago

_Server: https://uat-ads.platform3solutions.com/ Version: 2024.09.45542P4

Integer data type removed in metadata and add column. Due to integer data restricted, so we didn't get the above error in COC report. Metadata has integer data type image Upload integer metadata and it is failed. Metadata is not uploading showing error in BG job. image Logs for that image Try to add column for integer data type image Integer data type is not available image

Udhayanila8 commented 5 days ago

@abirami1994 , the given fix is working fine. Unable to upload the metadata if that has integer data type. Also unable to add the integer datatype column manually.

But need clarification, If existing application has integer datatype how this fix will work and i guess it is restricted only from ADS, if ingestion is triggered from ETL then how this fix will work?

UmashankarPalanichamy commented 5 days ago

@Udhayanila8 @ashoksri0 @kilam005 @suseela22 @Nadarajan-suyambu. As discussed with the ADS team, the INTEGER type has been removed from the ADS flow and is provided in version 2024.10.45588_P2, released on 07/11/2024.

Nadarajan-suyambu commented 4 days ago

PR link: https://github.com/P3-Core-Dev-Team/ADS_BE/pull/3345