search

P3-Core-Dev-Team / P3-Q-A

This repo is for tracking features
Other
0 stars 0 forks source link

Field Label - character length issue #36

Closed suseela22 closed 1 month ago

suseela22 commented 6 months ago

The field label is accepting only 20 characters. If there is a requirement having the label name more than 20 characters it will become an issue

image

kilam005 commented 5 months ago

@suseela22 I'm planning to increase this to upto 30. Kindly confirm if this is ok else what should be the ideal expectations?

kilam005 commented 5 months ago

@suseela22 Kindly confirm the ideal max character length.

suseela22 commented 5 months ago

@kilam005 There is no such limitation in IA for Label or binding name. I could not able to conclude to have max of 30 characters. Can't we give infinite? Does the max limit is playing major role? If so this needs a discussion with my team.

kilam005 commented 5 months ago

@suseela22

It is part of best practices. To avoid bloating and manage api request size properly. in DB also there is a limit for each data type. So as part of validation pen test team recommended we have some max limits. Also if there is infinite character acceptance, i can wantedly make the field take 1GB worth characters. Also the UI appearance and rendering should be considered.

So please discuss with the team and get the max definite and considerable value.

kilam005 commented 3 months ago

@suseela22 awaiting final confirmation over this.

kilam005 commented 3 months ago

@suseela22 Please provide info or i'll have this length fixed to 30.

suseela22 commented 3 months ago

Please have the characters fixed to 30 now. Have discussed with the team, so far we don't have any column having more than 30 characters. If we ran into new case in the upcoming project we will request for an enhancement.

kilam005 commented 3 months ago

This is currently in testing phase

yowanrajan commented 3 months ago

increased to 30 characters

Screenshot 2024-03-27 at 3 03 39 PM

Max character length 20 to changed 30

kilam005 commented 2 months ago

@ClementJosh21 : Was the Verification done for this change in BE side?

ClementJosh21 commented 2 months ago

@kilam005 The issue has been address in BE and attaching the PR link here.

kilam005 commented 2 months ago

@prabhakaranUI / @ClementJosh21 Let me know when this version is avaialble for release. ALso include details on which version this is going to come?

@Udhayanila8 please test and provide verified tag

Udhayanila8 commented 2 months ago

Maximum characters fixed as 30 now. Fixed in 146 server. Tested in 146 server.

image

kilam005 commented 1 month ago

@suseela22 we have update this and based on internal discussions, instead of 30 we have fixed it as 50. Kindly check and provide closure

suseela22 commented 1 month ago

Working as expected

kilam005 commented 1 month ago

Fix Details Feature additions were included