ADS-Search in background - Suggestion on the popup display- Effectv/Dell

P3-Core-Dev-Team / P3-Q-A

This repo is for tracking features

Other

0 stars 0 forks source link

ADS-Search in background - Suggestion on the popup display- Effectv/Dell #94

Closed raniangamuthu closed 2 weeks ago

raniangamuthu commented 3 months ago

Bug/Suggestion When trying to cancel the background job, it is understandable that the cancellation is not possible while the job is running or completed, but the response should not be red error alert kind. Suggestion to display as a message and not like an Error.

Steps to reproduce the behavior: Search Form >> Execute search in background >> try to cancel the background job.

Screenshots Screenshot 2024-03-05 084640

Additional context Build no: ADS v2024.01.45313 Client: Effectv

kilam005 commented 3 months ago

@raniangamuthu how do you think it has to be treated?

Suggestion: We can change the text "Error" and make it as NOTE or somthing similar. Red color is used to ensure attention. I can make this as a pop-up with warning or info.

Please provide info to proceed

raniangamuthu commented 3 months ago

The background request cannot be deleted as it has been processed/completed can be a message instead of error. Below is the message from infoarchive for reference

kilam005 commented 3 months ago

@prabhakaranUI / @ClementJosh21 please proceed accordingly to the comments above.

@maheswarareddyi please check and help

maheswarareddyi commented 3 months ago

@kilam005 @prabhakaranUI @ClementJosh21

Recommended solution for this issue fix:

We shouldn't allow the users to perform an action that is not supposed to be done concerning the current job status (Display the icon in disabled mode on the UI screen)
For the rest API service we can use the following message "The requested action cannot be processed because the job "<job name>" is currently in the status "<status>" ".

ShaliniSettu commented 2 months ago

RCA Technical issue. We will use different api's to kill or cancel the jobs according to that specific jobs status. This issue occurs when the user tries to kill the job that is in the state of scheduled when they triggered but when it reaches BE that job's status were update to in-progress, so that's why this issue has occurred.

Fix details Fixed this issue with inter calling api to kill that job according to their status.

kilam005 commented 2 months ago

@ClementJosh21 / @ShaliniSettu : in which version will this be out? or is this already out?

kilam005 commented 2 months ago

@Udhayanila8 were you able to test it?

Udhayanila8 commented 1 month ago

Able to cancel and stop the job while it is schedule and in-progress status. Tested version: 2024.03.45398_RC1 Tested server: 192.168.56.146

kilam005 commented 1 month ago

@Udhayanila8 please recheck this and if everything is working as expected update the Verified tag and add Awaiting Closure and move to Rani for verification and closure

Udhayanila8 commented 1 month ago

Verified 2024.05.45423_RC1 version. Tested in 146 and 218 servers. Hence moving this issue to rani. 218 server recording https://github.com/P3-Core-Dev-Team/P3-Q-A/assets/82999693/1e863e47-a5ed-4859-a897-d767da68a394

kilam005 commented 1 month ago

Based on last comment marking as verified

kilam005 commented 1 month ago

@raniangamuthu this is waiting for closure since May 15th. Please verify and provide closure soon.

based on testing team's confirmation, i will have to auto close this is no action is taken from your side by Jun 7th

kilam005 commented 2 weeks ago

@raniangamuthu since there is no response and no concerns raised. this issue is marked closed.