Fix a number of clippy errors

P3KI / bendy

A rust library for encoding and decoding bencode with enforced cannonicalization rules.

BSD 3-Clause "New" or "Revised" License

77 stars 14 forks source link

Fix a number of clippy errors #56

Closed thequux closed 3 years ago

thequux commented 3 years ago

I'm not entirely sure that this will still work with 1.36, but that's what CI is for :grin:

thequux commented 3 years ago

OK, this looks like it's OK for review. We bumped up from a MSRV of 1.36 when we introduced the use of #[non_exhaustive], thus the failing 1.36 builds. The failing 1.38 build is, I think, a transient error relating to unpacking Rust, so nothing we need to worry about.

thequux commented 3 years ago

Looking closer at this, it's an update to memchr that breaks compatibility with 1.36, so we'll need to update MSRV separately. That got merged in #57, but unfortunately, I can't re-run the CI pipeline merged with the new master. Alas. I'm merging it anyway, and will fix any resulting breakage.