search

P3pp3rF1y / Reliquary

The source code of Reliquary! That mod, with the magical swag, and a weapon, and stuff.
Other
44 stars 33 forks source link

1.18 version of the mod creates an infinitely recursive TranslatableComponent #569

Closed diesieben07 closed 2 years ago

diesieben07 commented 2 years ago

https://github.com/P3pp3rF1y/Reliquary/blob/8097df43e0fe9fc478a6283b98da9c68cfd2f1a0/src/main/java/reliquary/items/block/BlockItemBase.java#L31 This line creates a TranslatableComponent with two parameters: null and the tooltips list. Since the list will then later contain this TranslatableComponent, the component effectively contains itself as an argument. This causes crashes like this: https://bytebin.lucko.me/tTiGqaNjkt

P3pp3rF1y commented 2 years ago

Thanks for letting me know, apparently relic of a bit of refactoring that I didn't catch in testing. Will be released soon.