search

P3pp3rF1y / Reliquary

The source code of Reliquary! That mod, with the magical swag, and a weapon, and stuff.
Other
44 stars 33 forks source link

Crashed due to "concurrentmodificationexception" on latest patch #674

Closed Hmloughin closed 5 months ago

Hmloughin commented 5 months ago

Hello!

I updated to the latest patch today. I don't have any reliquaries because this is a relatively new world so I haven't had a chance to interact with the mod yet. I was exploring trying to find a particular POI when my game froze and then crashed. I talked with someone in the Curseforge discord to make sure it wasn't anything I did wrong when I was updating a bunch of mods and they confirmed that Reliquary was the issue.

Here's my latest log and crash report. Hope it helps! latest.log crash-2024-04-07_17.27.46-server.txt

P3pp3rF1y commented 5 months ago

Seems like some mod is making it so that entities tick in parallel instead of one after each other and hence the crash. Potentially it could be lithium though I am not sure which one that is as you have a ton that modify vanilla code. I guess I will introduce concurrent collection there and hopefully that won't hurt performance much when this is done the usual way - one after each other.

Hmloughin commented 5 months ago

Thanks for the quick response. Yeah, I have a LOT of mods and used a base set of performance optimizers to support having a bunch of fun mods. There's conflict occasionally, but this time it was something I didn't know how to deal with without disabling the mode entirely.

I'm sorry if this creates otherwise unnecessary problems for you.

P3pp3rF1y commented 5 months ago

Actually looks like this was related to triggering the code on client side as well when it wasn't required so in the latest release this was fixed to only trigger on server side