search

P3pp3rF1y / Reliquary

The source code of Reliquary! That mod, with the magical swag, and a weapon, and stuff.
Other
44 stars 33 forks source link

[Bug] 🐞 Crash - Possible Conflict With Touhou Little Maid Mod #675

Closed serioos closed 5 months ago

serioos commented 5 months ago

I was getting attacked by one of those Touhou Little Maid fairies and she hit me a few times before the game crashed with reliquary as the cause. I think the fairy might have spawned with one of reliquary items on her?

I have a crash log here:

https://pastebin.com/cWtMBwGw

Here's my mod list:

https://pastebin.com/C1hB48AQ

Minecraft Forge 1.20.1 - 42.2.20

reliquary-1.20.1-2.0.40.1224.jar touhoulittlemaid-1.20.1-release-1.1.8.jar

P3pp3rF1y commented 5 months ago

Nope this is a case of one of the ton of mods that you have there changing entity processing to be parallel which doesn't work with the logic I have that is made for single thread entity processing as is usual in MC. there's already a bug for that #674 . I will introduce a concurrent safe collection though I can't guarantee what else (what other mod) may break because of that other mod making this change.

P3pp3rF1y commented 5 months ago

Actually looks like this was related to triggering the code on client side as well when it wasn't required so in the latest release this was fixed to only trigger on server side